Make Error 'cause' non-enumerable and add tests

Define the `cause` property with Object.defineProperty in SensitiveInfoError and HookError so it remains non-enumerable (matching native ES2022 Error semantics) while keeping compatibility with TS libs predating ES2022. Add tests to verify cause chaining, non-enumerability, and omission when not provided. Also update CI workflow triggers to use the 'master' branch for android, ios and test workflows.

Author: mCodex

.github/workflows/android-build.yml

@@ -6,7 +6,7 @@ permissions:
 on:
   push:
     branches:
-      - main
+      - master
     paths:
       - '.github/workflows/android-build.yml'
       - 'example/android/**'

.github/workflows/ios-build.yml

@@ -6,7 +6,7 @@ permissions:
 on:
   push:
     branches:
-      - main
+      - master
     paths:
       - '.github/workflows/ios-build.yml'
       - 'example/ios/**'

.github/workflows/test.yml

@@ -6,7 +6,7 @@ permissions:
 on:
   push:
     branches:
-      - main
+      - master
     paths:
       - '.github/workflows/test.yml'
       - 'src/**'

src/__tests__/errors.test.ts

@@ -61,6 +61,39 @@ describe('errors', () => {
 			const err = new KeyInvalidatedError('invalid', { alias: 'rnsi.svc.v1' })
 			expect(err.alias).toBe('rnsi.svc.v1')
 		})
+
+		describe('cause chaining', () => {
+			it('retains the provided cause on SensitiveInfoError', () => {
+				const cause = new Error('underlying')
+				const err = new SensitiveInfoError(ErrorCode.NotFound, 'wrapped', {
+					cause,
+				})
+				expect(err.cause).toBe(cause)
+			})
+
+			it('keeps cause non-enumerable to match native ES2022 Error semantics', () => {
+				const cause = new Error('underlying')
+				const err = new SensitiveInfoError(ErrorCode.NotFound, 'wrapped', {
+					cause,
+				})
+				const descriptor = Object.getOwnPropertyDescriptor(err, 'cause')
+				expect(descriptor).toBeDefined()
+				expect(descriptor?.enumerable).toBe(false)
+				expect(Object.keys(err)).not.toContain('cause')
+				expect(JSON.parse(JSON.stringify(err))).not.toHaveProperty('cause')
+			})
+
+			it('does not define cause when not provided', () => {
+				const err = new SensitiveInfoError(ErrorCode.NotFound, 'wrapped')
+				expect(Object.hasOwn(err, 'cause')).toBe(false)
+			})
+
+			it('propagates cause through subclasses (NotFoundError)', () => {
+				const cause = new Error('native miss')
+				const err = new NotFoundError('missing', { cause })
+				expect(err.cause).toBe(cause)
+			})
+		})
 	})
 
 	describe('toSensitiveInfoError', () => {

src/__tests__/hooks.types.test.ts

@@ -19,6 +19,22 @@ describe('hooks/types', () => {
 		expect(error.hint).toBe('Check the key.')
 	})
 
+	it('keeps cause non-enumerable to match native ES2022 Error semantics', () => {
+		const cause = new Error('native failure')
+		const error = new HookError('Wrapper message', { cause })
+
+		const descriptor = Object.getOwnPropertyDescriptor(error, 'cause')
+		expect(descriptor).toBeDefined()
+		expect(descriptor?.enumerable).toBe(false)
+		expect(Object.keys(error)).not.toContain('cause')
+		expect(JSON.parse(JSON.stringify(error))).not.toHaveProperty('cause')
+	})
+
+	it('omits cause when not provided', () => {
+		const error = new HookError('Wrapper message')
+		expect(Object.hasOwn(error, 'cause')).toBe(false)
+	})
+
 	it('creates the initial async state', () => {
 		const state = createInitialAsyncState<string>()
 		expect(state).toEqual({

src/errors.ts

@@ -75,11 +75,17 @@ export class SensitiveInfoError extends Error {
 		super(message)
 		this.name = 'SensitiveInfoError'
 		this.code = code
-		// Assign `cause` directly instead of passing it to `super()` so this
+		// Define `cause` manually instead of passing it to `super()` so this
 		// compiles cleanly under TS configs whose `lib` predates ES2022 (where
-		// the second `Error` constructor argument was introduced).
+		// the second `Error` constructor argument was introduced), while keeping
+		// the property non-enumerable to match the native ES2022 `Error` constructor.
 		if (options && 'cause' in options) {
-			;(this as { cause?: unknown }).cause = options.cause
+			Object.defineProperty(this, 'cause', {
+				value: options.cause,
+				writable: true,
+				configurable: true,
+				enumerable: false,
+			})
 		}
 	}
 }

src/hooks/types.ts

@@ -42,11 +42,17 @@ export class HookError extends Error {
 		this.name = 'HookError'
 		this.operation = operation
 		this.hint = hint
-		// Assign `cause` directly instead of passing it to `super()` so this
+		// Define `cause` manually instead of passing it to `super()` so this
 		// compiles cleanly under TS configs whose `lib` predates ES2022 (where
-		// the second `Error` constructor argument was introduced).
+		// the second `Error` constructor argument was introduced), while keeping
+		// the property non-enumerable to match the native ES2022 `Error` constructor.
 		if (cause !== undefined) {
-			;(this as { cause?: unknown }).cause = cause
+			Object.defineProperty(this, 'cause', {
+				value: cause,
+				writable: true,
+				configurable: true,
+				enumerable: false,
+			})
 		}
 	}
 }