Skip to content

Commit f7b1d9e

Browse files
jamesnroktclaude
andauthored
fix: set iOS wrapper SDK version and cover RoktPaymentExtension in release flow (#95)
The release workflow only ever versioned/published the plugin and Rokt kit, leaving two gaps: - CDVMParticle.m reported an empty wrapper version to mParticle (_setWrapperSdk_internal version:@""). Seed it with the current version and add a release-workflow step that bumps it alongside plugin.xml, so it tracks every release instead of going stale. - Kits/RoktPaymentExtension (new this release) was not managed by the release flow at all, so it had drifted to 3.0.0 and would never be version-bumped or published. Add version-bump + plugin.xml + dry-run-publish steps mirroring the Rokt kit, align it to 3.0.1, and list the extra files in the release PR body. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent dd86530 commit f7b1d9e

4 files changed

Lines changed: 22 additions & 5 deletions

File tree

.github/workflows/draft-release-publish.yml

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,20 @@ jobs:
6868
run: |
6969
npm version ${{ steps.bump-version.outputs.new_version }} --no-git-tag-version
7070
71+
- name: Update Rokt Payment Extension package.json
72+
working-directory: Kits/RoktPaymentExtension
73+
run: |
74+
npm version ${{ steps.bump-version.outputs.new_version }} --no-git-tag-version
75+
7176
- name: Update plugin.xml versions
7277
run: |
7378
sed -i '' "s/version=\"[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\"/version=\"${{ steps.bump-version.outputs.new_version }}\"/" plugin/plugin.xml
7479
sed -i '' "s/version=\"[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\"/version=\"${{ steps.bump-version.outputs.new_version }}\"/" Kits/Rokt/plugin.xml
80+
sed -i '' "s/version=\"[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\"/version=\"${{ steps.bump-version.outputs.new_version }}\"/" Kits/RoktPaymentExtension/plugin.xml
81+
82+
- name: Update iOS wrapper SDK version
83+
run: |
84+
sed -i '' "s/_setWrapperSdk_internal:MPWrapperSdkCordova version:@\"[0-9.]*\"/_setWrapperSdk_internal:MPWrapperSdkCordova version:@\"${{ steps.bump-version.outputs.new_version }}\"/" plugin/src/ios/CDVMParticle.m
7585
7686
- name: Publish Plugin to npm (dry-run)
7787
working-directory: plugin
@@ -81,6 +91,10 @@ jobs:
8191
working-directory: Kits/Rokt
8292
run: npm publish --dry-run
8393

94+
- name: Publish Rokt Payment Extension to npm (dry-run)
95+
working-directory: Kits/RoktPaymentExtension
96+
run: npm publish --dry-run
97+
8498
- name: Update changelog
8599
uses: thomaseizinger/keep-a-changelog-new-release@f62c3c390716df5af712ba5d94f4f4a8efc1306d # v3.1.0
86100
with:
@@ -108,14 +122,17 @@ jobs:
108122
body: |
109123
Preparing for release ${{ steps.bump-version.outputs.new_version }}
110124
111-
There should be 6 files that have been updated:
125+
There should be 9 files that have been updated:
112126
- plugin/package.json
113127
- plugin/plugin.xml
128+
- plugin/src/ios/CDVMParticle.m
114129
- Kits/Rokt/package.json
115130
- Kits/Rokt/plugin.xml
131+
- Kits/RoktPaymentExtension/package.json
132+
- Kits/RoktPaymentExtension/plugin.xml
116133
- CHANGELOG.md
117134
- VERSION
118135
119-
Additionally a dry-run publish was successfully run for the plugin and Rokt kit.
136+
Additionally a dry-run publish was successfully run for the plugin, Rokt kit, and Rokt payment extension.
120137
labels: |
121138
release

Kits/RoktPaymentExtension/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@mparticle/cordova-rokt-payment-extension",
3-
"version": "3.0.0",
3+
"version": "3.0.1",
44
"description": "Adds Rokt payment extension support (Apple Pay, AfterPay/Clearpay, PayPal via Stripe) to your Cordova project",
55
"homepage": "https://www.mparticle.com",
66
"repository": {

Kits/RoktPaymentExtension/plugin.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<plugin xmlns="http://cordova.apache.org/ns/plugins/1.0"
33
id="@mparticle/cordova-rokt-payment-extension"
4-
version="3.0.0">
4+
version="3.0.1">
55
<name>MParticle Rokt Payment Extension Kit</name>
66
<description>Adds Rokt payment extension support (Apple Pay, AfterPay/Clearpay, PayPal via Stripe) to your Cordova project</description>
77
<platform name="ios">

plugin/src/ios/CDVMParticle.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ @interface CDVMParticle : CDVPlugin
99
@implementation CDVMParticle
1010

1111
- (void)pluginInitialize {
12-
[MParticle _setWrapperSdk_internal:MPWrapperSdkCordova version:@""];
12+
[MParticle _setWrapperSdk_internal:MPWrapperSdkCordova version:@"3.0.1"];
1313
}
1414

1515
- (void)logEvent:(CDVInvokedUrlCommand*)command {

0 commit comments

Comments
 (0)