feat: Implement Rokt selectPlacements#34
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for Rokt's selectPlacements functionality in the MParticle Cordova plugin. The implementation provides a cross-platform interface for configuring and executing Rokt placement selection with support for color modes, caching, and display options.
Key Changes
- Add selectPlacements JavaScript API with configuration options for color mode, caching, and edge-to-edge display
- Implement native iOS and Android selectPlacements methods that bridge to the respective Rokt SDKs
- Update SDK dependencies to support Rokt integration (mParticle SDK v5.71.0 for Android, v8.35.0 for iOS)
Reviewed Changes
Copilot reviewed 19 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| plugin/www/mparticle.js | Adds selectPlacements function and RoktColorMode enum with config merging logic |
| plugin/src/ios/CDVMParticle.m | Implements iOS selectPlacements bridge and fixes user identities conversion |
| plugin/src/android/.../MParticleCordovaPlugin.java | Implements Android selectPlacements bridge with Rokt SDK integration |
| plugin/plugin.xml | Updates SDK versions and iOS podspec configuration |
| example/ files | Comprehensive example application updates with testing interface and build improvements |
Files not reviewed (2)
- example/package-lock.json: Language not supported
- plugin/package-lock.json: Language not supported
rmi22186
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)