chore: add additional meta data to package.json#48
Merged
Conversation
thomson-t
reviewed
Dec 19, 2025
| @@ -5,6 +5,9 @@ | |||
| "homepage": "https://www.mparticle.com", | |||
| "repository": "mParticle/cordova-plugin-mparticle", | |||
Contributor
There was a problem hiding this comment.
Is this enough?
Don't we need the full repo url like
"repository": {
"type": "git",
"url": "https://github.com/mParticle/cordova-plugin-mparticle"
}
Member
Author
There was a problem hiding this comment.
Good call - I forgot we ran into this error when releasing the react native rokt sdk previously.
| "repository": "mParticle/cordova-plugin-mparticle", | ||
| "license": "Apache-2.0", | ||
| "publishConfig": { | ||
| "access": "public" |
Contributor
There was a problem hiding this comment.
Do we need?
"provenance": true,
"registry": "https://registry.npmjs.org"
Member
Author
There was a problem hiding this comment.
Good question - I actually originally had this since its what we had put for a few other repos. I was re-reviewing the docs and it states:
When you publish using trusted publishing, npm automatically generates and publishes [provenance attestations](https://docs.npmjs.com/generating-provenance-statements) for your package. This happens by default—you don't need to add the --provenance flag to your publish command.
And we technically don't need the registry because its in the workflow. However, I agree that it doesn't hurt to have both of these in package.json so I'ill include, as it'll be consistent w workflows we know definitely work
Member
Author
|
@thomson-t updated, please have another look |
thomson-t
approved these changes
Dec 19, 2025
jamesnrokt
added a commit
that referenced
this pull request
Jan 13, 2026
* feat: Add Rokt Kit package * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove check for VERSION file changes Co-authored-by: Thomson Thomas <125323226+thomson-t@users.noreply.github.com> * Separate functions for easier testing * Add token to PR creation Co-authored-by: Robert Ing <ring@mparticle.com> * Change contents permission * Add symlink for README in plugin * Add track conversion button to match Ads docs * Namespace Rokt functionality * Add prepublish step * chore: add additional meta data to package.json (#48) * Apply suggestions from code review Co-authored-by: Robert Ing <ring@mparticle.com> * Update code format --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Thomson Thomas <125323226+thomson-t@users.noreply.github.com> Co-authored-by: Robert Ing <ring@mparticle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Adding a
publishConfigoption to package.json to future proof our npm publish releases in case we ever scope the package, which is currently calledcordova-plugin-mparticleto@mparticle/cordova-pluginor similar. The original cordova plugin was published to npm prior to scoping of packages existing and we had just kept it this way.What Has Changed
Screenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)