Skip to content

fix: pin android-core upper bound to prevent 6.0.0-rc.1 pull#89

Merged
nickolas-dimitrakas merged 2 commits into
mainfrom
chore/pin-mparticle-version-range-rc1
May 27, 2026
Merged

fix: pin android-core upper bound to prevent 6.0.0-rc.1 pull#89
nickolas-dimitrakas merged 2 commits into
mainfrom
chore/pin-mparticle-version-range-rc1

Conversation

@jamesnrokt

Copy link
Copy Markdown
Contributor

Summary

  • Replace open-ended com.mparticle:android-core:+ range with [5.0,6.0) in plugin/src/android/build.gradle.
  • Same fix on the matching testImplementation line.

Why

com.mparticle:android-core:6.0.0-rc.1 was published to Maven Central on 2026-05-22. The + selector resolves to the highest available version, which is now the RC. 6.x removed deprecated symbols, so anyone consuming this plugin in a fresh build now resolves a kit-base API the plugin source can't compile against.

See mParticle/mparticle-android-sdk#710 for the broader incident affecting all Android consumers using dynamic ranges.

Test plan

  • cordova build android succeeds against a project that uses this plugin.
  • Plugin's own gradle build resolves a 5.x version of android-core (not the RC).

🤖 Generated with Claude Code

The open-ended `+` range resolves to the highest available version on
Maven Central — now `6.0.0-rc.1` (published 2026-05-22). 6.x removed
deprecated symbols, breaking standalone plugin builds.

See mParticle/mparticle-android-sdk#710 for the broader incident.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 27, 2026 19:44
@jamesnrokt
jamesnrokt requested a review from a team as a code owner May 27, 2026 19:44
@cursor

cursor Bot commented May 27, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Dependency and CI JDK bumps only; no runtime auth or data-path changes, and the cap restores predictable 5.x resolution for builds.

Overview
Pins com.mparticle:android-core to [5.0,6.0) for both compileOnly and testImplementation in plugin/src/android/build.gradle, replacing + so Gradle no longer picks 6.0.0-rc.1 from Maven Central (which breaks this plugin’s use of removed APIs). A short comment points at mparticle-android-sdk#710.

CI: the Android unit-test job in .github/workflows/pull-request.yml now uses JDK 17 instead of 11, aligning the workflow with the example Android job’s Java version.

Reviewed by Cursor Bugbot for commit 8812639. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit edd593a. Configure here.

Comment thread plugin/src/android/build.gradle

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent Android builds of the Cordova mParticle plugin from resolving com.mparticle:android-core:6.0.0-rc.1 (and newer 6.x pre-releases) by replacing the dynamic + selector with an explicit upper-bounded range in the plugin’s Android Gradle dependency declarations.

Changes:

  • Replace com.mparticle:android-core:+ with a bounded version range for compileOnly.
  • Apply the same bounded version range for testImplementation.
  • Add an inline comment explaining the rationale and linking to the upstream incident.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugin/src/android/build.gradle
Comment thread plugin/src/android/build.gradle
thomson-t
thomson-t previously approved these changes May 27, 2026
android-core 5.79.0 (resolved by the [5.0,6.0) range) is compiled with
Java 17 (class file version 61.0). Running the unit-test job on JDK 11
(class file version 55.0) causes a "bad class file" error at compile time.
Aligns the android-test job with the example-android job which already
uses JDK 17 successfully.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nickolas-dimitrakas
nickolas-dimitrakas dismissed stale reviews from thomson-t and themself via 8812639 May 27, 2026 20:47
@nickolas-dimitrakas
nickolas-dimitrakas merged commit 0a1d968 into main May 27, 2026
11 checks passed
@nickolas-dimitrakas
nickolas-dimitrakas deleted the chore/pin-mparticle-version-range-rc1 branch May 27, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants