Skip to content

ci: include plugin.xml files in version bump and release commit#92

Merged
nickolas-dimitrakas merged 3 commits into
mainfrom
fix/include-plugin-xml-in-release
May 28, 2026
Merged

ci: include plugin.xml files in version bump and release commit#92
nickolas-dimitrakas merged 3 commits into
mainfrom
fix/include-plugin-xml-in-release

Conversation

@nickolas-dimitrakas

@nickolas-dimitrakas nickolas-dimitrakas commented May 27, 2026

Copy link
Copy Markdown
Contributor

Summary

draft-release-publish.yml only bumped package.json files via npm version, leaving plugin/plugin.xml and Kits/Rokt/plugin.xml stale on every release. Cordova uses plugin.xml as the canonical version descriptor, so this caused a version mismatch at install time (surfaced in #90).

  • draft-release-publish.yml — adds a step to sed-update the version= attribute in both plugin.xml files immediately after the npm version calls; updates the PR body checklist from 4 → 6 files
  • release.yml, release.config.js, .scripts/release.sh — removed; the old semantic-release path has never been run and draft-release-publish.yml is the sole active release workflow

Screenshots/Video

  • N/A

Additional Notes

Reference Issue (For employees only. Ignore if you are an outside contributor)

  • N/A

…mmit

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 27, 2026 21:20
@nickolas-dimitrakas nickolas-dimitrakas requested a review from a team as a code owner May 27, 2026 21:20
@cursor

cursor Bot commented May 27, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes how releases are produced (workflow swap) and touches version metadata used at Cordova install time; incorrect sed patterns could leave mismatched versions.

Overview
Release automation is consolidated on the draft release workflow and Cordova plugin.xml versions are bumped with the rest of the release.

The Create draft release workflow now runs sed to set the version= attribute in plugin/plugin.xml and Kits/Rokt/plugin.xml to the new semver, and the release PR template expects six updated files (adding both plugin.xml paths alongside the existing package.json, CHANGELOG.md, and VERSION updates).

The older semantic-release path is removed: .github/workflows/release.yml, release.config.js, and .scripts/release.sh are deleted so releases no longer go through that manual/dispatch semantic-release + npm job flow.

Reviewed by Cursor Bugbot for commit 17dc4dc. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the semantic-release path so Cordova plugin.xml version attributes are bumped and committed alongside package metadata, reducing install-time version mismatches.

Changes:

  • Adds plugin/plugin.xml and Kits/Rokt/plugin.xml to semantic-release git assets.
  • Updates .scripts/release.sh to rewrite version="X.Y.Z" attributes in both plugin.xml files.
  • Stages the updated XML files with the release commit.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
release.config.js Includes both Cordova XML descriptors in semantic-release commit assets.
.scripts/release.sh Applies release version updates to plugin XML files and stages them.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .scripts/release.sh Outdated
@nickolas-dimitrakas nickolas-dimitrakas changed the title fix(release): include plugin.xml files in version bump and release commit ci: include plugin.xml files in version bump and release commit May 27, 2026
nickolas-dimitrakas and others added 2 commits May 27, 2026 17:31
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
release.yml, release.config.js, and .scripts/release.sh are dead code —
release.yml has never been run and draft-release-publish.yml has been the
active release path since the Rokt kit was added.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nickolas-dimitrakas nickolas-dimitrakas merged commit f57e4d1 into main May 28, 2026
11 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the fix/include-plugin-xml-in-release branch May 28, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants