ci: include plugin.xml files in version bump and release commit#92
Conversation
…mmit Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PR SummaryMedium Risk Overview The Create draft release workflow now runs The older semantic-release path is removed: Reviewed by Cursor Bugbot for commit 17dc4dc. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Pull request overview
This PR updates the semantic-release path so Cordova plugin.xml version attributes are bumped and committed alongside package metadata, reducing install-time version mismatches.
Changes:
- Adds
plugin/plugin.xmlandKits/Rokt/plugin.xmlto semantic-release git assets. - Updates
.scripts/release.shto rewriteversion="X.Y.Z"attributes in bothplugin.xmlfiles. - Stages the updated XML files with the release commit.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
release.config.js |
Includes both Cordova XML descriptors in semantic-release commit assets. |
.scripts/release.sh |
Applies release version updates to plugin XML files and stages them. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
release.yml, release.config.js, and .scripts/release.sh are dead code — release.yml has never been run and draft-release-publish.yml has been the active release path since the Rokt kit was added. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
draft-release-publish.ymlonly bumpedpackage.jsonfiles vianpm version, leavingplugin/plugin.xmlandKits/Rokt/plugin.xmlstale on every release. Cordova usesplugin.xmlas the canonical version descriptor, so this caused a version mismatch at install time (surfaced in #90).draft-release-publish.yml— adds a step tosed-update theversion=attribute in bothplugin.xmlfiles immediately after thenpm versioncalls; updates the PR body checklist from 4 → 6 filesrelease.yml,release.config.js,.scripts/release.sh— removed; the old semantic-release path has never been run anddraft-release-publish.ymlis the sole active release workflowScreenshots/Video
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)