Skip to content

Commit 0e00b32

Browse files
Address review comments
1 parent f8836fa commit 0e00b32

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

android-kit-base/src/main/java/com/mparticle/kits/KitManagerImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1373,7 +1373,7 @@ public void execute(String viewName,
13731373
}
13741374
Map<String, Object> objectAttributes = new HashMap<>();
13751375
for (Map.Entry<String, String> entry : finalAttributes.entrySet()) {
1376-
if(!finalAttributes.containsKey(Constants.MessageKey.SANDBOX_MODE_ROKT)) {
1376+
if(!entry.getKey().equals(Constants.MessageKey.SANDBOX_MODE_ROKT)) {
13771377
objectAttributes.put(entry.getKey(), entry.getValue());
13781378
}
13791379
}

android-kit-base/src/test/kotlin/com/mparticle/kits/KitManagerImplTest.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -852,6 +852,7 @@ class KitManagerImplTest {
852852
Assert.assertEquals("Test1", attributes["lastname"])
853853
Assert.assertEquals("Test", attributes["test"])
854854
Assert.assertEquals("US", attributes["country"])
855+
Assert.assertEquals("false", attributes["sandbox"])
855856
}
856857

857858
@Test
@@ -917,6 +918,7 @@ class KitManagerImplTest {
917918
Assert.assertEquals("Test1", attributes["lastname"])
918919
Assert.assertEquals("Test", attributes["test"])
919920
Assert.assertEquals("US", attributes["country"])
921+
Assert.assertEquals("false", attributes["sandbox"])
920922
}
921923

922924
@Test
@@ -981,6 +983,7 @@ class KitManagerImplTest {
981983
Assert.assertEquals("Test1", attributes["lastname"])
982984
Assert.assertEquals("Test", attributes["test"])
983985
Assert.assertEquals("US", attributes["country"])
986+
Assert.assertEquals("false", attributes["sandbox"])
984987
}
985988

986989
@Test
@@ -1044,6 +1047,7 @@ class KitManagerImplTest {
10441047
Assert.assertEquals("Test1", attributes["lastname"])
10451048
Assert.assertEquals("Test", attributes["test"])
10461049
Assert.assertEquals("US", attributes["country"])
1050+
Assert.assertEquals("false", attributes["sandbox"])
10471051
}
10481052

10491053
@Test

0 commit comments

Comments
 (0)