Skip to content

Commit 43163a9

Browse files
committed
fix security issues
1 parent 2bb9331 commit 43163a9

6 files changed

Lines changed: 11 additions & 10 deletions

File tree

.mobsf

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111

1212
ignore-rules:
1313
- webview_javascript_interface # Intentional: JS bridge for mParticle WebView SDK; workspace token controls access
14+
- android_manifest_insecure_minsdk_error # Example apps; SDK minSdk 14+ per AGENTS.md
15+
- android_manifest_allow_backup # Example apps only; acceptable for demo/debug
1416
- hardcoded_api_key
1517
- hardcoded_username
1618
- android_kotlin_hardcoded

kits/braze/braze-38/example/src/main/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
package="com.mparticle.kits.braze.example">
44

55
<application
6-
android:allowBackup="true"
6+
android:allowBackup="false"
77
android:icon="@mipmap/ic_launcher"
88
android:label="@string/app_name"
99
android:roundIcon="@mipmap/ic_launcher_round"

kits/braze/braze-38/src/test/kotlin/com/mparticle/kits/AppboyKitTests.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ import org.mockito.Mockito
3131
import org.mockito.MockitoAnnotations
3232
import java.lang.reflect.Method
3333
import java.math.BigDecimal
34+
import java.security.SecureRandom
3435
import java.util.Calendar
3536
import java.util.Locale
36-
import java.util.Random
3737

3838
class AppboyKitTests {
39-
private var random = Random()
39+
private var random = SecureRandom()
4040

4141
private lateinit var braze: Braze.Companion
4242

kits/ga/ga-23/src/test/kotlin/com/mparticle/kits/GoogleAnalyticsFirebaseKitTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ import org.mockito.MockitoAnnotations
3333
import java.lang.ref.WeakReference
3434
import java.lang.reflect.Method
3535
import java.lang.reflect.Modifier
36+
import java.security.SecureRandom
3637
import java.util.HashMap
37-
import java.util.Random
3838

3939
/**
4040
* Example local unit test, which will execute on the development machine (host).
@@ -44,7 +44,7 @@ import java.util.Random
4444
class GoogleAnalyticsFirebaseKitTest {
4545
private lateinit var kitInstance: GoogleAnalyticsFirebaseKit
4646
private lateinit var firebaseSdk: FirebaseAnalytics
47-
var random = Random()
47+
var random = SecureRandom()
4848

4949
@Mock
5050
lateinit var user: MParticleUser

kits/ga4/ga4-23/src/test/kotlin/com/mparticle/kits/GoogleAnalyticsFirebaseGA4KitTest.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ import org.mockito.MockitoAnnotations
3535
import java.lang.ref.WeakReference
3636
import java.lang.reflect.Method
3737
import java.lang.reflect.Modifier
38+
import java.security.SecureRandom
3839
import java.util.HashMap
39-
import java.util.Random
4040

4141
/**
4242
* Example local unit test, which will execute on the development machine (host).
@@ -46,15 +46,14 @@ import java.util.Random
4646
class GoogleAnalyticsFirebaseGA4KitTest {
4747
private lateinit var kitInstance: GoogleAnalyticsFirebaseGA4Kit
4848
private lateinit var firebaseSdk: FirebaseAnalytics
49+
private var random = SecureRandom()
4950

5051
@Mock
5152
lateinit var user: MParticleUser
5253

5354
@Mock
5455
lateinit var filteredMParticleUser: FilteredMParticleUser
5556

56-
private var random = Random()
57-
5857
@Before
5958
@Throws(JSONException::class)
6059
fun before() {

kits/leanplum/leanplum-7/leanplum-example/src/main/AndroidManifest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
xmlns:tools="http://schemas.android.com/tools"
44
package="com.mparticle.example.leanplum">
55
<uses-sdk
6-
android:minSdkVersion="10"
6+
android:minSdkVersion="14"
77
tools:overrideLibrary="com.leanplum, com.google.android.gms"/>
88
<application
99
android:name=".ExampleApplication"
10-
android:allowBackup="true"
10+
android:allowBackup="false"
1111
android:icon="@mipmap/ic_launcher"
1212
android:label="@string/app_name"
1313
android:roundIcon="@mipmap/ic_launcher_round"

0 commit comments

Comments
 (0)