Skip to content

Commit 5d009a2

Browse files
committed
Extract LogoutListener to top-level interface for Kotlin kits
Move LogoutListener out of KitIntegration into com.mparticle.kits.LogoutListener so kits resolve the type from published android-kit-base (fixes Kotlin Unresolved reference in CI). Update KitManagerImpl and kit implementations. Made-with: Cursor
1 parent 4848718 commit 5d009a2

18 files changed

Lines changed: 34 additions & 31 deletions

File tree

android-kit-base/src/androidTest/kotlin/com/mparticle/kits/testkits/AttributeListenerTestKit.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package com.mparticle.kits.testkits
22

33
import com.mparticle.MParticle
44
import com.mparticle.kits.KitIntegration
5-
import com.mparticle.kits.KitIntegration.LogoutListener
5+
import com.mparticle.kits.LogoutListener
66
import com.mparticle.kits.ReportingMessage
77

88
open class AttributeListenerTestKit :

android-kit-base/src/main/java/com/mparticle/kits/KitIntegration.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -345,21 +345,6 @@ public interface SessionListener {
345345
List<ReportingMessage> onSessionEnd();
346346
}
347347

348-
/**
349-
* Kits may implement this interface to respond when the mParticle Identity API performs a logout.
350-
*/
351-
public interface LogoutListener {
352-
353-
/**
354-
* The mParticle SDK exposes a logout API, allowing developers to track an event
355-
* when a user logs out of their app/platform. Use this opportunity to perform the appropriate logic
356-
* as per your platforms logout paradigm, such as clearing user attributes.
357-
*
358-
* @return Kits should return a List of ReportingMessages indicating that the logout was processed one or more times, or null if it was not processed
359-
*/
360-
List<ReportingMessage> logout();
361-
}
362-
363348
/**
364349
* Kits should implement this interface when their underlying service has the notion
365350
* of a user with attributes.

android-kit-base/src/main/java/com/mparticle/kits/KitManagerImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
import com.mparticle.internal.Logger;
4040
import com.mparticle.internal.MPUtility;
4141
import com.mparticle.internal.ReportingManager;
42-
import com.mparticle.kits.KitIntegration.LogoutListener;
42+
import com.mparticle.kits.LogoutListener;
4343
import com.mparticle.kits.mappings.CustomMapping;
4444
import com.mparticle.rokt.RoktOptions;
4545

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
package com.mparticle.kits;
2+
3+
import java.util.List;
4+
5+
/**
6+
* Kits may implement this interface to respond when the mParticle Identity API performs a logout.
7+
*/
8+
public interface LogoutListener {
9+
10+
/**
11+
* The mParticle SDK exposes a logout API, allowing developers to track an event
12+
* when a user logs out of their app/platform. Use this opportunity to perform the appropriate logic
13+
* as per your platforms logout paradigm, such as clearing user attributes.
14+
*
15+
* @return Kits should return a List of ReportingMessages indicating that the logout was processed one or more times, or null if it was not processed
16+
*/
17+
List<ReportingMessage> logout();
18+
}

kits/adobe/adobe-5/src/main/kotlin/com/mparticle/kits/AdobeKitBase.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import com.mparticle.internal.MPUtility
77
import com.mparticle.internal.MPUtility.AdIdInfo
88
import com.mparticle.kits.KitIntegration.ApplicationStateListener
99
import com.mparticle.kits.KitIntegration.AttributeListener
10-
import com.mparticle.kits.KitIntegration.LogoutListener
10+
import com.mparticle.kits.LogoutListener
1111
import com.mparticle.kits.KitIntegration.PushListener
1212
import org.json.JSONException
1313
import org.json.JSONObject

kits/adobemedia/adobemedia-5/src/main/kotlin/com/mparticle/kits/AdobeKit.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import com.mparticle.MParticle
2020
import com.mparticle.kits.KitIntegration.ApplicationStateListener
2121
import com.mparticle.kits.KitIntegration.AttributeListener
2222
import com.mparticle.kits.KitIntegration.EventListener
23-
import com.mparticle.kits.KitIntegration.LogoutListener
23+
import com.mparticle.kits.LogoutListener
2424
import com.mparticle.kits.KitIntegration.PushListener
2525
import com.mparticle.media.events.ContentType
2626
import com.mparticle.media.events.EventAttributes

kits/appsflyer/appsflyer-6/src/main/kotlin/com/mparticle/kits/AppsFlyerKit.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import com.mparticle.commerce.Product
3131
import com.mparticle.consent.ConsentState
3232
import com.mparticle.internal.Logger
3333
import com.mparticle.internal.MPUtility
34-
import com.mparticle.kits.KitIntegration.LogoutListener
34+
import com.mparticle.kits.LogoutListener
3535
import org.json.JSONArray
3636
import org.json.JSONException
3737
import org.json.JSONObject

kits/apptimize/apptimize-3/src/main/kotlin/com/mparticle/kits/ApptimizeKit.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import com.mparticle.MParticle.IdentityType
1313
import com.mparticle.commerce.CommerceEvent
1414
import com.mparticle.kits.KitIntegration.AttributeListener
1515
import com.mparticle.kits.KitIntegration.CommerceListener
16-
import com.mparticle.kits.KitIntegration.LogoutListener
16+
import com.mparticle.kits.LogoutListener
1717
import java.math.BigDecimal
1818

1919
class ApptimizeKit :

kits/branch/branch-5/src/main/kotlin/com/mparticle/kits/BranchMetricsKit.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import com.mparticle.kits.KitIntegration.AttributeListener
1515
import com.mparticle.kits.KitIntegration.CommerceListener
1616
import com.mparticle.kits.KitIntegration.EventListener
1717
import com.mparticle.kits.KitIntegration.IdentityListener
18-
import com.mparticle.kits.KitIntegration.LogoutListener
18+
import com.mparticle.kits.LogoutListener
1919
import io.branch.referral.Branch
2020
import io.branch.referral.Branch.BranchReferralInitListener
2121
import io.branch.referral.BranchError

kits/braze/braze-38/src/main/kotlin/com/mparticle/kits/AppboyKit.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ import com.mparticle.kits.KitIntegration.AttributeListener
3535
import com.mparticle.kits.KitIntegration.CommerceListener
3636
import com.mparticle.kits.KitIntegration.EventListener
3737
import com.mparticle.kits.KitIntegration.IdentityListener
38-
import com.mparticle.kits.KitIntegration.LogoutListener
38+
import com.mparticle.kits.LogoutListener
3939
import com.mparticle.kits.KitIntegration.PushListener
4040
import com.mparticle.kits.KitIntegration.UserAttributeListener
4141
import org.json.JSONArray

0 commit comments

Comments
 (0)