Skip to content

Commit 7524884

Browse files
denischilikdenischilik
committed
Fix Braze kit tests for two-arg onConsentStateUpdated
KitIntegration.UserAttributeListener now passes only old and new ConsentState. Drop the removed FilteredMParticleUser argument and unused mock from AppboyKitTests across braze-38 through braze-41. Made-with: Cursor
1 parent a898a52 commit 7524884

4 files changed

Lines changed: 16 additions & 56 deletions

File tree

‎kits/braze/braze-38/src/test/kotlin/com/mparticle/kits/AppboyKitTests.kt‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,6 @@ class AppboyKitTests {
4343
@Mock
4444
private val mTypeFilters: SparseBooleanArray? = null
4545

46-
@Mock
47-
lateinit var filteredMParticleUser: FilteredMParticleUser
48-
4946
@Mock
5047
lateinit var user: MParticleUser
5148

@@ -1333,9 +1330,7 @@ class AppboyKitTests {
13331330
.builder()
13341331
.addGDPRConsentState("Marketing", marketingConsent)
13351332
.build()
1336-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1337-
1338-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1333+
kit.onConsentStateUpdated(state, state)
13391334
TestCase.assertEquals(
13401335
false,
13411336
currentUser.getCustomUserAttribute()["\$google_ad_personalization"],
@@ -1381,9 +1376,7 @@ class AppboyKitTests {
13811376
.addGDPRConsentState("Marketing", marketingConsent)
13821377
.addGDPRConsentState("Performance", performanceConsent)
13831378
.build()
1384-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1385-
1386-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1379+
kit.onConsentStateUpdated(state, state)
13871380
TestCase.assertEquals(true, currentUser.getCustomUserAttribute()["\$google_ad_user_data"])
13881381
TestCase.assertEquals(
13891382
true,
@@ -1418,8 +1411,7 @@ class AppboyKitTests {
14181411
.addGDPRConsentState("Marketing", marketingConsent)
14191412
.addGDPRConsentState("Performance", performanceConsent)
14201413
.build()
1421-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1422-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1414+
kit.onConsentStateUpdated(state, state)
14231415
TestCase.assertEquals(0, currentUser.getCustomUserAttribute().size)
14241416
}
14251417

@@ -1459,9 +1451,7 @@ class AppboyKitTests {
14591451
.addGDPRConsentState("Marketing", marketingConsent)
14601452
.addGDPRConsentState("Performance", performanceConsent)
14611453
.build()
1462-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1463-
1464-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1454+
kit.onConsentStateUpdated(state, state)
14651455

14661456
TestCase.assertEquals(0, currentUser.getCustomUserAttribute().size)
14671457
}

‎kits/braze/braze-39/src/test/kotlin/com/mparticle/kits/AppboyKitTests.kt‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,6 @@ class AppboyKitTests {
4343
@Mock
4444
private val mTypeFilters: SparseBooleanArray? = null
4545

46-
@Mock
47-
lateinit var filteredMParticleUser: FilteredMParticleUser
48-
4946
@Mock
5047
lateinit var user: MParticleUser
5148

@@ -1333,9 +1330,7 @@ class AppboyKitTests {
13331330
.builder()
13341331
.addGDPRConsentState("Marketing", marketingConsent)
13351332
.build()
1336-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1337-
1338-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1333+
kit.onConsentStateUpdated(state, state)
13391334
TestCase.assertEquals(
13401335
false,
13411336
currentUser.getCustomUserAttribute()["\$google_ad_personalization"],
@@ -1381,9 +1376,7 @@ class AppboyKitTests {
13811376
.addGDPRConsentState("Marketing", marketingConsent)
13821377
.addGDPRConsentState("Performance", performanceConsent)
13831378
.build()
1384-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1385-
1386-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1379+
kit.onConsentStateUpdated(state, state)
13871380
TestCase.assertEquals(true, currentUser.getCustomUserAttribute()["\$google_ad_user_data"])
13881381
TestCase.assertEquals(
13891382
true,
@@ -1418,8 +1411,7 @@ class AppboyKitTests {
14181411
.addGDPRConsentState("Marketing", marketingConsent)
14191412
.addGDPRConsentState("Performance", performanceConsent)
14201413
.build()
1421-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1422-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1414+
kit.onConsentStateUpdated(state, state)
14231415
TestCase.assertEquals(0, currentUser.getCustomUserAttribute().size)
14241416
}
14251417

@@ -1459,9 +1451,7 @@ class AppboyKitTests {
14591451
.addGDPRConsentState("Marketing", marketingConsent)
14601452
.addGDPRConsentState("Performance", performanceConsent)
14611453
.build()
1462-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1463-
1464-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1454+
kit.onConsentStateUpdated(state, state)
14651455

14661456
TestCase.assertEquals(0, currentUser.getCustomUserAttribute().size)
14671457
}

‎kits/braze/braze-40/src/test/kotlin/com/mparticle/kits/AppboyKitTests.kt‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,6 @@ class AppboyKitTests {
4343
@Mock
4444
private val mTypeFilters: SparseBooleanArray? = null
4545

46-
@Mock
47-
lateinit var filteredMParticleUser: FilteredMParticleUser
48-
4946
@Mock
5047
lateinit var user: MParticleUser
5148

@@ -1333,9 +1330,7 @@ class AppboyKitTests {
13331330
.builder()
13341331
.addGDPRConsentState("Marketing", marketingConsent)
13351332
.build()
1336-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1337-
1338-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1333+
kit.onConsentStateUpdated(state, state)
13391334
TestCase.assertEquals(
13401335
false,
13411336
currentUser.getCustomUserAttribute()["\$google_ad_personalization"],
@@ -1381,9 +1376,7 @@ class AppboyKitTests {
13811376
.addGDPRConsentState("Marketing", marketingConsent)
13821377
.addGDPRConsentState("Performance", performanceConsent)
13831378
.build()
1384-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1385-
1386-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1379+
kit.onConsentStateUpdated(state, state)
13871380
TestCase.assertEquals(true, currentUser.getCustomUserAttribute()["\$google_ad_user_data"])
13881381
TestCase.assertEquals(
13891382
true,
@@ -1418,8 +1411,7 @@ class AppboyKitTests {
14181411
.addGDPRConsentState("Marketing", marketingConsent)
14191412
.addGDPRConsentState("Performance", performanceConsent)
14201413
.build()
1421-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1422-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1414+
kit.onConsentStateUpdated(state, state)
14231415
TestCase.assertEquals(0, currentUser.getCustomUserAttribute().size)
14241416
}
14251417

@@ -1459,9 +1451,7 @@ class AppboyKitTests {
14591451
.addGDPRConsentState("Marketing", marketingConsent)
14601452
.addGDPRConsentState("Performance", performanceConsent)
14611453
.build()
1462-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1463-
1464-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1454+
kit.onConsentStateUpdated(state, state)
14651455

14661456
TestCase.assertEquals(0, currentUser.getCustomUserAttribute().size)
14671457
}

‎kits/braze/braze-41/src/test/kotlin/com/mparticle/kits/AppboyKitTests.kt‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,6 @@ class AppboyKitTests {
4343
@Mock
4444
private val mTypeFilters: SparseBooleanArray? = null
4545

46-
@Mock
47-
lateinit var filteredMParticleUser: FilteredMParticleUser
48-
4946
@Mock
5047
lateinit var user: MParticleUser
5148

@@ -1333,9 +1330,7 @@ class AppboyKitTests {
13331330
.builder()
13341331
.addGDPRConsentState("Marketing", marketingConsent)
13351332
.build()
1336-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1337-
1338-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1333+
kit.onConsentStateUpdated(state, state)
13391334
TestCase.assertEquals(
13401335
false,
13411336
currentUser.getCustomUserAttribute()["\$google_ad_personalization"],
@@ -1381,9 +1376,7 @@ class AppboyKitTests {
13811376
.addGDPRConsentState("Marketing", marketingConsent)
13821377
.addGDPRConsentState("Performance", performanceConsent)
13831378
.build()
1384-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1385-
1386-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1379+
kit.onConsentStateUpdated(state, state)
13871380
TestCase.assertEquals(true, currentUser.getCustomUserAttribute()["\$google_ad_user_data"])
13881381
TestCase.assertEquals(
13891382
true,
@@ -1418,8 +1411,7 @@ class AppboyKitTests {
14181411
.addGDPRConsentState("Marketing", marketingConsent)
14191412
.addGDPRConsentState("Performance", performanceConsent)
14201413
.build()
1421-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1422-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1414+
kit.onConsentStateUpdated(state, state)
14231415
TestCase.assertEquals(0, currentUser.getCustomUserAttribute().size)
14241416
}
14251417

@@ -1459,9 +1451,7 @@ class AppboyKitTests {
14591451
.addGDPRConsentState("Marketing", marketingConsent)
14601452
.addGDPRConsentState("Performance", performanceConsent)
14611453
.build()
1462-
filteredMParticleUser = FilteredMParticleUser.getInstance(user, kit)
1463-
1464-
kit.onConsentStateUpdated(state, state, filteredMParticleUser)
1454+
kit.onConsentStateUpdated(state, state)
14651455

14661456
TestCase.assertEquals(0, currentUser.getCustomUserAttribute().size)
14671457
}

0 commit comments

Comments
 (0)