Pass Identity api instance directly instead of full mPInstance

Author: Mansi-mParticle

android-kit-base/src/main/java/com/mparticle/kits/KitManagerImpl.java

@@ -1343,7 +1343,7 @@ public void execute(String viewName,
                     MParticle instance = MParticle.getInstance();
                     MParticleUser user = instance.Identity().getCurrentUser();
                     String email = attributes != null ? attributes.get("email") : null;
-                    confirmEmail(email,user,instance, () -> {
+                    confirmEmail(email,user,instance.Identity(), () -> {
                     JSONArray jsonArray = new JSONArray();
 
                     KitConfiguration kitConfig = provider.getConfiguration();
@@ -1386,7 +1386,7 @@ public void execute(String viewName,
     private void confirmEmail(
             @Nullable String email,
             @Nullable MParticleUser user,
-            MParticle instance,
+            IdentityApi identityApi,
             Runnable runnable
     ) {
         if (email != null && user != null) {
@@ -1406,7 +1406,7 @@ private void confirmEmail(
                 IdentityApiRequest identityRequest = IdentityApiRequest.withUser(user)
                         .email(email)
                         .build();
-                MParticleTask<IdentityApiResult> task = instance.Identity().identify(identityRequest);
+                MParticleTask<IdentityApiResult> task = identityApi.identify(identityRequest);
                 task.addFailureListener(new TaskFailureListener() {
                     @Override
                     public void onFailure(IdentityHttpResponse result) {

android-kit-base/src/test/kotlin/com/mparticle/kits/KitManagerImplTest.kt

@@ -1079,11 +1079,11 @@ class KitManagerImplTest {
             "confirmEmail",
             String::class.java,
             MParticleUser::class.java,
-            MParticle::class.java,
+            IdentityApi::class.java,
             Runnable::class.java
         )
         method.isAccessible = true
-        val result = method.invoke(manager, "Test@gmail.com", user, instance, runnable)
+        val result = method.invoke(manager, "Test@gmail.com", user, identityApi, runnable)
         verify(mockTask).addSuccessListener(any())
     }
 
@@ -1126,11 +1126,11 @@ class KitManagerImplTest {
             "confirmEmail",
             String::class.java,
             MParticleUser::class.java,
-            MParticle::class.java,
+            IdentityApi::class.java,
             Runnable::class.java
         )
         method.isAccessible = true
-        val result = method.invoke(manager, "Test@gmail.com", user, instance, runnable)
+        val result = method.invoke(manager, "Test@gmail.com", user, identityApi, runnable)
         Mockito.verify(runnable).run()
     }
 
@@ -1173,11 +1173,11 @@ class KitManagerImplTest {
             "confirmEmail",
             String::class.java,
             MParticleUser::class.java,
-            MParticle::class.java,
+            IdentityApi::class.java,
             Runnable::class.java
         )
         method.isAccessible = true
-        val result = method.invoke(manager, null, user, instance, runnable)
+        val result = method.invoke(manager, null, user, identityApi, runnable)
         Mockito.verify(runnable).run()
     }
 
@@ -1220,11 +1220,11 @@ class KitManagerImplTest {
             "confirmEmail",
             String::class.java,
             MParticleUser::class.java,
-            MParticle::class.java,
+            IdentityApi::class.java,
             Runnable::class.java
         )
         method.isAccessible = true
-        val result = method.invoke(manager, null, user, instance, runnable)
+        val result = method.invoke(manager, null, user, identityApi, runnable)
         Mockito.verify(runnable).run()
     }