Skip to content

Commit 88a682c

Browse files
committed
feat: Add PlacementOptions support to Rokt integration
- Add integration start timestamp to the `PlacementOptions` object and pass it down to RoktKit - Add unit tests
1 parent 4a3a7f8 commit 88a682c

4 files changed

Lines changed: 6 additions & 26 deletions

File tree

android-core/src/main/kotlin/com/mparticle/Rokt.kt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ import java.lang.ref.WeakReference
1414
@ApiClass
1515
class Rokt internal constructor(private val mConfigManager: ConfigManager, private val mKitManager: KitManager) {
1616

17-
companion object {
18-
const val JOINT_SDK_SELECT_PLACEMENTS = "jointSdkSelectPlacements"
19-
}
20-
2117
@JvmOverloads
2218
fun selectPlacements(
2319
identifier: String,
@@ -78,6 +74,6 @@ class Rokt internal constructor(private val mConfigManager: ConfigManager, priva
7874
}
7975

8076
private fun buildPlacementOptions(): PlacementOptions = PlacementOptions(
81-
performanceMarkers = mutableMapOf(JOINT_SDK_SELECT_PLACEMENTS to System.currentTimeMillis()),
77+
jointSdkSelectPlacements = System.currentTimeMillis(),
8278
)
8379
}
Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
package com.mparticle.rokt
22

3-
data class PlacementOptions(val performanceMarkers: MutableMap<String, Long>)
3+
data class PlacementOptions(
4+
val jointSdkSelectPlacements: Long,
5+
val dynamicPerformanceMarkers: MutableMap<String, Long> = mutableMapOf(),
6+
)

android-kit-base/src/main/java/com/mparticle/kits/KitIntegration.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -619,13 +619,6 @@ public interface BatchListener {
619619
}
620620

621621
public interface RoktListener {
622-
void execute(@NonNull String viewName,
623-
@NonNull Map<String, String> attributes,
624-
@Nullable MpRoktEventCallback mpRoktEventCallback,
625-
@Nullable Map<String, WeakReference<RoktEmbeddedView>> placeHolders,
626-
@Nullable Map<String, WeakReference<Typeface>> fontTypefaces,
627-
@Nullable FilteredMParticleUser user,
628-
@Nullable RoktConfig config);
629622

630623
void execute(@NonNull String viewName,
631624
@NonNull Map<String, String> attributes,

android-kit-base/src/test/kotlin/com/mparticle/kits/KitManagerImplTest.kt

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1869,7 +1869,7 @@ class KitManagerImplTest {
18691869
}
18701870

18711871
val attributes = hashMapOf<String, String>()
1872-
val placementOptions = PlacementOptions(integrationStartTimestamp = 123L)
1872+
val placementOptions = PlacementOptions(jointSdkSelectPlacements = 123L)
18731873

18741874
manager.execute("Test", attributes, null, null, null, null, placementOptions)
18751875

@@ -2327,18 +2327,6 @@ class KitManagerImplTest {
23272327

23282328
override fun getConfiguration(): KitConfiguration = config
23292329

2330-
override fun execute(
2331-
viewName: String,
2332-
attributes: MutableMap<String, String>,
2333-
mpRoktEventCallback: MpRoktEventCallback?,
2334-
placeHolders: MutableMap<String, WeakReference<RoktEmbeddedView>>?,
2335-
fontTypefaces: MutableMap<String, WeakReference<Typeface>>?,
2336-
user: FilteredMParticleUser?,
2337-
config: RoktConfig?,
2338-
) {
2339-
Logger.info("Executed with $attributes")
2340-
}
2341-
23422330
override fun execute(
23432331
viewName: String,
23442332
attributes: MutableMap<String, String>,

0 commit comments

Comments
 (0)