Skip to content

Commit 99da62b

Browse files
committed
address sonar cube comments
1 parent b262ce9 commit 99da62b

1 file changed

Lines changed: 36 additions & 36 deletions

File tree

android-kit-base/src/main/java/com/mparticle/kits/KitManagerImpl.java

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -887,8 +887,8 @@ public void logBatch(String batch) {
887887
public void leaveBreadcrumb(String breadcrumb) {
888888
for (KitIntegration provider : activeKits()) {
889889
try {
890-
if (provider instanceof KitIntegration.EventListener) {
891-
List<ReportingMessage> report = ((KitIntegration.EventListener) provider).leaveBreadcrumb(breadcrumb);
890+
if (provider instanceof KitIntegration.EventListener listener) {
891+
List<ReportingMessage> report = listener.leaveBreadcrumb(breadcrumb);
892892
getReportingManager().logAll(report);
893893
mCoreCallbacks.getKitListener().onKitApiCalled(provider.getConfiguration().getKitId(), !MPUtility.isEmpty(report), breadcrumb);
894894
}
@@ -902,8 +902,8 @@ public void leaveBreadcrumb(String breadcrumb) {
902902
public void logError(String message, Map<String, String> eventData) {
903903
for (KitIntegration provider : activeKits()) {
904904
try {
905-
if (provider instanceof KitIntegration.EventListener) {
906-
List<ReportingMessage> report = ((KitIntegration.EventListener) provider).logError(message, eventData);
905+
if (provider instanceof KitIntegration.EventListener listener) {
906+
List<ReportingMessage> report = listener.logError(message, eventData);
907907
getReportingManager().logAll(report);
908908
mCoreCallbacks.getKitListener().onKitApiCalled(provider.getConfiguration().getKitId(), !MPUtility.isEmpty(report), message, eventData);
909909
}
@@ -917,8 +917,8 @@ public void logError(String message, Map<String, String> eventData) {
917917
public void logException(Exception exception, Map<String, String> eventData, String message) {
918918
for (KitIntegration provider : activeKits()) {
919919
try {
920-
if (provider instanceof KitIntegration.EventListener) {
921-
List<ReportingMessage> report = ((KitIntegration.EventListener) provider).logException(exception, eventData, message);
920+
if (provider instanceof KitIntegration.EventListener listener) {
921+
List<ReportingMessage> report = listener.logException(exception, eventData, message);
922922
getReportingManager().logAll(report);
923923
mCoreCallbacks.getKitListener().onKitApiCalled(provider.getConfiguration().getKitId(), !MPUtility.isEmpty(report), exception, message, eventData);
924924
}
@@ -1004,8 +1004,8 @@ public void logScreen(MPEvent screenEvent) {
10041004
public void onActivityCreated(Activity activity, Bundle savedInstanceState) {
10051005
for (KitIntegration provider : activeKits()) {
10061006
try {
1007-
if (provider instanceof KitIntegration.ActivityListener) {
1008-
List<ReportingMessage> reportingMessages = ((KitIntegration.ActivityListener) provider).onActivityCreated(activity, savedInstanceState);
1007+
if (provider instanceof KitIntegration.ActivityListener listener) {
1008+
List<ReportingMessage> reportingMessages = listener.onActivityCreated(activity, savedInstanceState);
10091009
getReportingManager().logAll(reportingMessages);
10101010
}
10111011
} catch (Exception e) {
@@ -1018,8 +1018,8 @@ public void onActivityCreated(Activity activity, Bundle savedInstanceState) {
10181018
public void onActivityStarted(Activity activity) {
10191019
for (KitIntegration provider : activeKits()) {
10201020
try {
1021-
if (provider instanceof KitIntegration.ActivityListener) {
1022-
List<ReportingMessage> reportingMessages = ((KitIntegration.ActivityListener) provider).onActivityStarted(activity);
1021+
if (provider instanceof KitIntegration.ActivityListener listener) {
1022+
List<ReportingMessage> reportingMessages = listener.onActivityStarted(activity);
10231023
getReportingManager().logAll(reportingMessages);
10241024
}
10251025
} catch (Exception e) {
@@ -1032,8 +1032,8 @@ public void onActivityStarted(Activity activity) {
10321032
public void onActivityResumed(Activity activity) {
10331033
for (KitIntegration provider : activeKits()) {
10341034
try {
1035-
if (provider instanceof KitIntegration.ActivityListener) {
1036-
List<ReportingMessage> reportingMessages = ((KitIntegration.ActivityListener) provider).onActivityResumed(activity);
1035+
if (provider instanceof KitIntegration.ActivityListener listener) {
1036+
List<ReportingMessage> reportingMessages = listener.onActivityResumed(activity);
10371037
getReportingManager().logAll(reportingMessages);
10381038
}
10391039
} catch (Exception e) {
@@ -1046,8 +1046,8 @@ public void onActivityResumed(Activity activity) {
10461046
public void onActivityPaused(Activity activity) {
10471047
for (KitIntegration provider : activeKits()) {
10481048
try {
1049-
if (provider instanceof KitIntegration.ActivityListener) {
1050-
List<ReportingMessage> reportingMessages = ((KitIntegration.ActivityListener) provider).onActivityPaused(activity);
1049+
if (provider instanceof KitIntegration.ActivityListener listener) {
1050+
List<ReportingMessage> reportingMessages = listener.onActivityPaused(activity);
10511051
getReportingManager().logAll(reportingMessages);
10521052
}
10531053
} catch (Exception e) {
@@ -1060,8 +1060,8 @@ public void onActivityPaused(Activity activity) {
10601060
public void onActivityStopped(Activity activity) {
10611061
for (KitIntegration provider : activeKits()) {
10621062
try {
1063-
if (provider instanceof KitIntegration.ActivityListener) {
1064-
List<ReportingMessage> reportingMessages = ((KitIntegration.ActivityListener) provider).onActivityStopped(activity);
1063+
if (provider instanceof KitIntegration.ActivityListener listener) {
1064+
List<ReportingMessage> reportingMessages = listener.onActivityStopped(activity);
10651065
getReportingManager().logAll(reportingMessages);
10661066
}
10671067
} catch (Exception e) {
@@ -1074,8 +1074,8 @@ public void onActivityStopped(Activity activity) {
10741074
public void onActivitySaveInstanceState(Activity activity, Bundle outState) {
10751075
for (KitIntegration provider : activeKits()) {
10761076
try {
1077-
if (provider instanceof KitIntegration.ActivityListener) {
1078-
List<ReportingMessage> reportingMessages = ((KitIntegration.ActivityListener) provider).onActivitySaveInstanceState(activity, outState);
1077+
if (provider instanceof KitIntegration.ActivityListener listener) {
1078+
List<ReportingMessage> reportingMessages = listener.onActivitySaveInstanceState(activity, outState);
10791079
getReportingManager().logAll(reportingMessages);
10801080
}
10811081
} catch (Exception e) {
@@ -1088,8 +1088,8 @@ public void onActivitySaveInstanceState(Activity activity, Bundle outState) {
10881088
public void onActivityDestroyed(Activity activity) {
10891089
for (KitIntegration provider : activeKits()) {
10901090
try {
1091-
if (provider instanceof KitIntegration.ActivityListener) {
1092-
List<ReportingMessage> reportingMessages = ((KitIntegration.ActivityListener) provider).onActivityDestroyed(activity);
1091+
if (provider instanceof KitIntegration.ActivityListener listener) {
1092+
List<ReportingMessage> reportingMessages = listener.onActivityDestroyed(activity);
10931093
getReportingManager().logAll(reportingMessages);
10941094
}
10951095
} catch (Exception e) {
@@ -1102,8 +1102,8 @@ public void onActivityDestroyed(Activity activity) {
11021102
public void onSessionEnd() {
11031103
for (KitIntegration provider : activeKits()) {
11041104
try {
1105-
if (provider instanceof KitIntegration.SessionListener) {
1106-
List<ReportingMessage> reportingMessages = ((KitIntegration.SessionListener) provider).onSessionEnd();
1105+
if (provider instanceof KitIntegration.SessionListener listener) {
1106+
List<ReportingMessage> reportingMessages = listener.onSessionEnd();
11071107
getReportingManager().logAll(reportingMessages);
11081108
}
11091109
} catch (Exception e) {
@@ -1209,8 +1209,8 @@ public void onUserIdentified(MParticleUser mParticleUser, MParticleUser previous
12091209
reloadKits();
12101210
for (KitIntegration provider : activeKits()) {
12111211
try {
1212-
if (provider instanceof KitIntegration.IdentityListener) {
1213-
((KitIntegration.IdentityListener) provider).onUserIdentified(FilteredMParticleUser.getInstance(mParticleUser, provider));
1212+
if (provider instanceof KitIntegration.IdentityListener listener) {
1213+
listener.onUserIdentified(FilteredMParticleUser.getInstance(mParticleUser, provider));
12141214
}
12151215
} catch (Exception e) {
12161216
Logger.warning("Failed to call onUserIdentified for kit: " + provider.getName() + ": " + e.getMessage());
@@ -1237,8 +1237,8 @@ public void onUserAttributesReceived(@NonNull Map<String, ?> userAttributes, @No
12371237
public void onIdentifyCompleted(MParticleUser mParticleUser, IdentityApiRequest identityApiRequest) {
12381238
for (KitIntegration provider : activeKits()) {
12391239
try {
1240-
if (provider instanceof KitIntegration.IdentityListener) {
1241-
((KitIntegration.IdentityListener) provider).onIdentifyCompleted(FilteredMParticleUser.getInstance(mParticleUser, provider), new FilteredIdentityApiRequest(identityApiRequest, provider));
1240+
if (provider instanceof KitIntegration.IdentityListener listener) {
1241+
listener.onIdentifyCompleted(FilteredMParticleUser.getInstance(mParticleUser, provider), new FilteredIdentityApiRequest(identityApiRequest, provider));
12421242
}
12431243
} catch (Exception e) {
12441244
Logger.warning("Failed to call onIdentifyCompleted for kit: " + provider.getName() + ": " + e.getMessage());
@@ -1250,8 +1250,8 @@ public void onIdentifyCompleted(MParticleUser mParticleUser, IdentityApiRequest
12501250
public void onLoginCompleted(MParticleUser mParticleUser, IdentityApiRequest identityApiRequest) {
12511251
for (KitIntegration provider : activeKits()) {
12521252
try {
1253-
if (provider instanceof KitIntegration.IdentityListener) {
1254-
((KitIntegration.IdentityListener) provider).onLoginCompleted(FilteredMParticleUser.getInstance(mParticleUser, provider), new FilteredIdentityApiRequest(identityApiRequest, provider));
1253+
if (provider instanceof KitIntegration.IdentityListener listener) {
1254+
listener.onLoginCompleted(FilteredMParticleUser.getInstance(mParticleUser, provider), new FilteredIdentityApiRequest(identityApiRequest, provider));
12551255
}
12561256
} catch (Exception e) {
12571257
Logger.warning("Failed to call onLoginCompleted for kit: " + provider.getName() + ": " + e.getMessage());
@@ -1263,8 +1263,8 @@ public void onLoginCompleted(MParticleUser mParticleUser, IdentityApiRequest ide
12631263
public void onLogoutCompleted(MParticleUser mParticleUser, IdentityApiRequest identityApiRequest) {
12641264
for (KitIntegration provider : activeKits()) {
12651265
try {
1266-
if (provider instanceof KitIntegration.IdentityListener) {
1267-
((KitIntegration.IdentityListener) provider).onLogoutCompleted(FilteredMParticleUser.getInstance(mParticleUser, provider), new FilteredIdentityApiRequest(identityApiRequest, provider));
1266+
if (provider instanceof KitIntegration.IdentityListener listener) {
1267+
listener.onLogoutCompleted(FilteredMParticleUser.getInstance(mParticleUser, provider), new FilteredIdentityApiRequest(identityApiRequest, provider));
12681268
}
12691269
} catch (Exception e) {
12701270
Logger.warning("Failed to call onLogoutCompleted for kit: " + provider.getName() + ": " + e.getMessage());
@@ -1276,8 +1276,8 @@ public void onLogoutCompleted(MParticleUser mParticleUser, IdentityApiRequest id
12761276
public void onModifyCompleted(MParticleUser mParticleUser, IdentityApiRequest identityApiRequest) {
12771277
for (KitIntegration provider : activeKits()) {
12781278
try {
1279-
if (provider instanceof KitIntegration.IdentityListener) {
1280-
((KitIntegration.IdentityListener) provider).onModifyCompleted(FilteredMParticleUser.getInstance(mParticleUser, provider), new FilteredIdentityApiRequest(identityApiRequest, provider));
1279+
if (provider instanceof KitIntegration.IdentityListener listener) {
1280+
listener.onModifyCompleted(FilteredMParticleUser.getInstance(mParticleUser, provider), new FilteredIdentityApiRequest(identityApiRequest, provider));
12811281
}
12821282
} catch (Exception e) {
12831283
Logger.warning("Failed to call onModifyCompleted for kit: " + provider.getName() + ": " + e.getMessage());
@@ -1313,8 +1313,8 @@ public void reset() {
13131313
@Nullable
13141314
public RoktKitApi getRoktKitApi() {
13151315
for (KitIntegration provider : activeKits()) {
1316-
if (provider instanceof KitIntegration.RoktListener) {
1317-
return new RoktKitApiImpl((KitIntegration.RoktListener) provider, provider);
1316+
if (provider instanceof KitIntegration.RoktListener listener) {
1317+
return new RoktKitApiImpl(listener, provider);
13181318
}
13191319
}
13201320
return null;
@@ -1324,8 +1324,8 @@ public RoktKitApi getRoktKitApi() {
13241324
public void setWrapperSdkVersion(@NonNull WrapperSdkVersion wrapperSdkVersion) {
13251325
for (KitIntegration provider : activeKits()) {
13261326
try {
1327-
if (provider instanceof KitIntegration.RoktListener) {
1328-
((KitIntegration.RoktListener) provider).setWrapperSdkVersion(wrapperSdkVersion);
1327+
if (provider instanceof KitIntegration.RoktListener listener) {
1328+
listener.setWrapperSdkVersion(wrapperSdkVersion);
13291329
}
13301330
} catch (Exception e) {
13311331
Logger.warning("Failed to call setWrapperSdkVersion for kit: " + provider.getName() + ": " + e.getMessage());

0 commit comments

Comments
 (0)