Skip to content

Commit b256eb7

Browse files
Address review commets
1 parent 0c85fd8 commit b256eb7

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

android-core/src/main/java/com/mparticle/MParticle.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1906,7 +1906,7 @@ public void selectPlacements(@NonNull String viewName,
19061906
}
19071907
}
19081908

1909-
public void reportConversion(@NonNull String placementId, @NonNull String catalogItemId, boolean status) {
1909+
public void purchaseFinalized(@NonNull String placementId, @NonNull String catalogItemId, boolean status) {
19101910
if (mConfigManager.isEnabled()) {
19111911
mKitManager.purchaseFinalized(placementId, catalogItemId, status);
19121912
}

android-core/src/test/kotlin/com/mparticle/MParticleTest.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import org.mockito.ArgumentCaptor
3030
import org.mockito.ArgumentMatchers
3131
import org.mockito.ArgumentMatchers.any
3232
import org.mockito.Mockito
33-
import org.mockito.Mockito.mock
3433
import org.mockito.Mockito.never
3534
import org.mockito.Mockito.verify
3635
import org.mockito.Mockito.`when`
@@ -540,7 +539,7 @@ class MParticleTest {
540539
val attributes = mutableMapOf<String, String>()
541540
attributes.put("a", "b")
542541

543-
instance.rokt.reportConversion("132", "1111", true)
542+
instance.rokt.purchaseFinalized("132", "1111", true)
544543

545544
verify(instance.mKitManager).purchaseFinalized("132", "1111", true)
546545
}
@@ -551,7 +550,7 @@ class MParticleTest {
551550
MParticle.setInstance(instance)
552551
`when`(instance.mConfigManager.isEnabled()).thenReturn(false)
553552

554-
instance.rokt.reportConversion("132", "1111", true)
553+
instance.rokt.purchaseFinalized("132", "1111", true)
555554

556555
verify(instance.mKitManager, never()).purchaseFinalized("132", "1111", true)
557556
}

android-kit-base/src/test/kotlin/com/mparticle/kits/KitManagerImplTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1453,7 +1453,7 @@ class KitManagerImplTest {
14531453
}
14541454

14551455
override fun purchaseFinalized(placementId: String, catalogItemId: String, status: Boolean) {
1456-
TODO("Not yet implemented")
1456+
println("purchaseFinalized with placementId: $placementId catalogItemId : $catalogItemId status : $status ")
14571457
}
14581458
}
14591459
internal inner class KitManagerEventCounter : MockKitManagerImpl() {

0 commit comments

Comments
 (0)