fix: correct shell loop in instrumented orchestrator tests

Author: Mansi-mParticle

.github/workflows/pull-request.yml

@@ -58,16 +58,16 @@ jobs:
           disable-animations: true
           script: |
             # Disable animations and clean up test packages
-            /bin/bash -c "
+            bash -eo pipefail -c '
               adb shell settings put global transition_animation_scale 0.0
               adb shell settings put global animator_duration_scale 0.0
 
               for pkg in com.mparticle.kittests com.mparticle.kits.test com.mparticle.legacyTest com.mparticle.test; do
-                if adb shell pm list packages | grep -q \"\$pkg\"; then
-                  adb uninstall \"\$pkg\"
+                if adb shell pm list packages | grep -q "$pkg"; then
+                  adb uninstall "$pkg"
                 fi
               done
-            "
+            '
 
             ./gradlew connectedCheck --info --stacktrace
 
@@ -130,11 +130,7 @@ jobs:
             adb shell settings put global transition_animation_scale 0.0
             adb shell settings put global animator_duration_scale 0.0
 
-            for pkg in com.mparticle.kittests com.mparticle.kits.test com.mparticle.legacyTest com.mparticle.test; do
-              if adb shell pm list packages | grep -q "$pkg"; then
-              adb uninstall "$pkg"
-              fi
-            done
+            for pkg in com.mparticle.kittests com.mparticle.kits.test com.mparticle.legacyTest com.mparticle.test; do adb shell pm list packages | grep -q "$pkg" && adb uninstall "$pkg"; done
 
             ./gradlew connectedCheck --stacktrace
             ./gradlew -Porchestrator=true :android-core:cAT -Pandroid.testInstrumentationRunnerArguments.androidx.benchmark.enabledRules=none