feat: move onSetUserAttributeList to BaseAttributeListener (#690)

* Delegate onSetUserAttributeList to setUserAttributeList (dual-interface kits)

Braze, AppsFlyer, and Singular implement both AttributeListener and
UserAttributeListener; wire empty onSetUserAttributeList to existing
setUserAttributeList behavior.

Made-with: Cursor

* Move onSetUserAttributeList to BaseAttributeListener

- Declare onSetUserAttributeList on BaseAttributeListener; remove from UserAttributeListener.
- KitManagerImpl calls BaseAttributeListener.onSetUserAttributeList for list attributes.
- AttributeListener-only kits delegate onSetUserAttributeList to setUserAttributeList.
- AttributeListenerTestKit implements onSetUserAttributeList via setUserAttributeList.

Made-with: Cursor

* test: KitManagerImplTest expect onSetUserAttributeList for list path

KitManagerImpl forwards list-valued attributes via BaseAttributeListener.onSetUserAttributeList when supportsAttributeLists is true.

Made-with: Cursor

* refactor: remove setUserAttributeList from AttributeListener

- Drop legacy two-arg setUserAttributeList from KitIntegration.AttributeListener;
  KitManagerImpl already forwards list attributes via onSetUserAttributeList.
- Kits: use private helpers (Braze, Localytics) or inline no-ops; Adobe kits call
  syncIds from onSetUserAttributeList only.
- AttributeListenerTestKit invokes list callback from onSetUserAttributeList.

Made-with: Cursor

* refactor: inline list attribute helpers into onSetUserAttributeList

- Braze: remove private setUserAttributeList; duplicate Braze getCurrentUser
  flow in onSetUserAttributeList and setAllUserAttributes initial sync.
- Localytics: call Localytics.setProfileAttribute directly from
  onSetUserAttributeList and setAllUserAttributes.

Made-with: Cursor

* Align onSetUserAttributeList parameter names with BaseAttributeListener

Rename Kotlin overrides and call sites to use attributeKey, attributeValueList,
and user consistently across kits and test kits.

Made-with: Cursor

* Document empty onSetUserAttributeList overrides with // not supported

Add a consistent comment for no-op kit implementations; align AppsFlyer
wording with other kits.

Made-with: Cursor

Author: denischilik

android-kit-base/src/androidTest/kotlin/com/mparticle/kits/testkits/AttributeListenerTestKit.kt

@@ -11,7 +11,7 @@ open class AttributeListenerTestKit :
     AttributeListener,
     LogoutListener {
     var setUserAttributeCallback: ((attributeKey: String?, attributeValue: String?) -> Unit)? = null
-    var setUserAttributeList: ((attributeKey: String?, attributeValueList: List<String?>?) -> Unit)? =
+    var setUserAttributeList: ((attributeKey: String?, attributeValueList: List<String>?) -> Unit)? =
         null
     var supportsAttributeLists: (() -> Boolean)? = null
     var setAllUserAttributes: ((userAttributes: Map<String, String>?, userAttributeLists: Map<String, List<String>>?) -> Unit)? =
@@ -24,9 +24,10 @@ open class AttributeListenerTestKit :
 
     override fun supportsAttributeLists() = supportsAttributeLists?.invoke() ?: true
 
-    override fun setUserAttributeList(
-        attributeKey: String,
-        attributeValueList: MutableList<String>,
+    override fun onSetUserAttributeList(
+        attributeKey: String?,
+        attributeValueList: List<String>?,
+        user: FilteredMParticleUser?,
     ) {
         setUserAttributeList?.invoke(attributeKey, attributeValueList)
         onAttributeReceived?.invoke(attributeKey, attributeValueList)

android-kit-base/src/androidTest/kotlin/com/mparticle/kits/testkits/UserAttributeListenerTestKit.kt

@@ -13,7 +13,7 @@ open class UserAttributeListenerTestKit :
     var onSetUserAttribute: ((key: String?, value: Any?, user: FilteredMParticleUser?) -> Unit)? =
         null
     var onSetUserTag: ((key: String?, user: FilteredMParticleUser?) -> Unit)? = null
-    var onSetUserAttributeList: ((attributeKey: String?, attributeValueList: List<String?>?, user: FilteredMParticleUser?) -> Unit)? =
+    var onSetUserAttributeList: ((attributeKey: String?, attributeValueList: List<String>?, user: FilteredMParticleUser?) -> Unit)? =
         null
     var onSetAllUserAttributes: (
         (
@@ -75,7 +75,7 @@ open class UserAttributeListenerTestKit :
 
     override fun onSetUserAttributeList(
         attributeKey: String?,
-        attributeValueList: MutableList<String>?,
+        attributeValueList: List<String>?,
         user: FilteredMParticleUser?,
     ) {
         onSetUserAttributeList?.invoke(attributeKey, attributeValueList, user)

android-kit-base/src/main/java/com/mparticle/kits/KitIntegration.java

@@ -396,12 +396,22 @@ public interface BaseAttributeListener {
          * @param user  filtered user context for this kit
          */
         void onSetUserAttribute(String key, Object value, FilteredMParticleUser user);
+
+        /**
+         * Called when a list-valued user attribute is set and {@link #supportsAttributeLists()} returns true.
+         *
+         * @param attributeKey       attribute key (may be null)
+         * @param attributeValueList attribute values (may be null)
+         * @param user               filtered user context for this kit (may be null)
+         */
+        void onSetUserAttributeList(
+                @Nullable String attributeKey,
+                @Nullable List<String> attributeValueList,
+                @Nullable FilteredMParticleUser user);
     }
 
     public interface AttributeListener extends BaseAttributeListener {
 
-        void setUserAttributeList(String attributeKey, List<String> attributeValueList);
-
         void setAllUserAttributes(Map<String, String> userAttributes, Map<String, List<String>> userAttributeLists);
 
         void setUserIdentity(MParticle.IdentityType identityType, String identity);
@@ -565,8 +575,6 @@ public interface UserAttributeListener extends BaseAttributeListener {
 
         void onSetUserTag(String key, FilteredMParticleUser user);
 
-        void onSetUserAttributeList(String attributeKey, List<String> attributeValueList, FilteredMParticleUser user);
-
         void onSetAllUserAttributes(Map<String, String> userAttributes, Map<String, List<String>> userAttributeLists, FilteredMParticleUser user);
 
         void onConsentStateUpdated(ConsentState oldState, ConsentState newState, FilteredMParticleUser user);

android-kit-base/src/main/java/com/mparticle/kits/KitManagerImpl.java

@@ -681,24 +681,15 @@ public void setUserAttributeList(String attributeKey, List<String> valuesList, l
     }
 
     private void setUserAttribute(KitIntegration provider, String attributeKey, List<String> valueList, long mpid) {
-        if ((provider instanceof KitIntegration.AttributeListener || provider instanceof KitIntegration.UserAttributeListener)
+        if ((provider instanceof KitIntegration.BaseAttributeListener listener)
                 && !provider.isDisabled()
                 && KitConfiguration.shouldForwardAttribute(provider.getConfiguration().getUserAttributeFilters(), attributeKey)) {
-            boolean supportsAttributeLists = ((KitIntegration.BaseAttributeListener) provider).supportsAttributeLists();
+            boolean supportsAttributeLists = listener.supportsAttributeLists();
             FilteredMParticleUser user = FilteredMParticleUser.getInstance(mpid, provider);
-            if (provider instanceof KitIntegration.AttributeListener) {
-                if (supportsAttributeLists) {
-                    ((KitIntegration.AttributeListener) provider).setUserAttributeList(attributeKey, valueList);
-                } else {
-                    ((KitIntegration.BaseAttributeListener) provider).onSetUserAttribute(attributeKey, KitUtils.join(valueList), user);
-                }
-            }
-            if (provider instanceof KitIntegration.UserAttributeListener) {
-                if (supportsAttributeLists) {
-                    ((KitIntegration.UserAttributeListener) provider).onSetUserAttributeList(attributeKey, valueList, user);
-                } else {
-                    ((KitIntegration.UserAttributeListener) provider).onSetUserAttribute(attributeKey, KitUtils.join(valueList), user);
-                }
+            if (supportsAttributeLists) {
+                listener.onSetUserAttributeList(attributeKey, valueList, user);
+            } else {
+                listener.onSetUserAttribute(attributeKey, KitUtils.join(valueList), user);
             }
         }
     }

android-kit-base/src/test/kotlin/com/mparticle/kits/KitManagerImplTest.kt

@@ -558,8 +558,8 @@ class KitManagerImplTest {
         attributeList.add("2")
         attributeList.add("3")
         manager.setUserAttributeList("test key", attributeList, 1)
-        verify(integration as AttributeListener, Mockito.times(1))
-            .setUserAttributeList("test key", attributeList)
+        verify(integration as BaseAttributeListener, Mockito.times(1))
+            .onSetUserAttributeList(eq("test key"), eq(attributeList), any())
         verify(integration2 as BaseAttributeListener, Mockito.times(1))
             .onSetUserAttribute(eq("test key"), eq("1,2,3"), isNull())
     }

kits/adobe/adobe-5/src/main/kotlin/com/mparticle/kits/AdobeKitBase.kt

@@ -48,9 +48,10 @@ abstract class AdobeKitBase :
         syncIds()
     }
 
-    override fun setUserAttributeList(
-        s: String,
-        list: List<String>,
+    override fun onSetUserAttributeList(
+        attributeKey: String?,
+        attributeValueList: List<String>?,
+        user: FilteredMParticleUser?,
     ) {
         syncIds()
     }

kits/adobemedia/adobemedia-5/src/main/kotlin/com/mparticle/kits/AdobeKit.kt

@@ -85,9 +85,10 @@ open class AdobeKit :
         syncIds()
     }
 
-    override fun setUserAttributeList(
-        s: String,
-        list: List<String>,
+    override fun onSetUserAttributeList(
+        attributeKey: String?,
+        attributeValueList: List<String>?,
+        user: FilteredMParticleUser?,
     ) {
         syncIds()
     }

kits/appsflyer/appsflyer-6/src/main/kotlin/com/mparticle/kits/AppsFlyerKit.kt

@@ -248,11 +248,6 @@ class AppsFlyerKit :
         return messageList
     }
 
-    override fun setUserAttributeList(
-        s: String,
-        list: List<String>,
-    ) {}
-
     override fun onIncrementUserAttribute(
         key: String?,
         incrementedBy: Number?,
@@ -283,9 +278,10 @@ class AppsFlyerKit :
 
     override fun onSetUserAttributeList(
         attributeKey: String?,
-        attributeValueList: MutableList<String>?,
+        attributeValueList: List<String>?,
         user: FilteredMParticleUser?,
     ) {
+        // not supported
     }
 
     override fun onSetAllUserAttributes(

kits/apptentive/apptentive-6/src/main/kotlin/com/mparticle/kits/ApptentiveKit.kt

@@ -143,7 +143,7 @@ class ApptentiveKit :
 
     override fun onSetUserAttributeList(
         attributeKey: String?,
-        attributeValueList: MutableList<String>?,
+        attributeValueList: List<String>?,
         user: FilteredMParticleUser?,
     ) {
         // Ignored

kits/apptimize/apptimize-3/src/main/kotlin/com/mparticle/kits/ApptimizeKit.kt

@@ -121,14 +121,12 @@ class ApptimizeKit :
 
     override fun getName(): String = KIT_NAME
 
-    /**
-     * Not supported by the Apptimize kit.
-     */
-    override fun setUserAttributeList(
-        key: String,
-        list: List<String>,
+    override fun onSetUserAttributeList(
+        attributeKey: String?,
+        attributeValueList: List<String>?,
+        user: FilteredMParticleUser?,
     ) {
-        // not supported
+        // not supported by the Apptimize kit
     }
 
     override fun supportsAttributeLists(): Boolean = false