Skip to content

Commit ed4ae98

Browse files
Addree review comments
1 parent 00f86da commit ed4ae98

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

android-kit-base/src/main/java/com/mparticle/kits/KitManagerImpl.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1528,11 +1528,11 @@ private void confirmEmail(
15281528
String identityTypeStr = (kitConfiguration != null)
15291529
? kitConfiguration.getHashedEmailUserIdentityType()
15301530
: null;
1531-
if (identityTypeStr != null && !identityTypeStr.equalsIgnoreCase("Unknown")) {
1531+
if (identityTypeStr != null ) {
15321532
selectedIdentityType = MParticle.IdentityType.valueOf(identityTypeStr);
15331533
}
15341534
} catch (IllegalArgumentException e) {
1535-
selectedIdentityType = MParticle.IdentityType.Other; // fallback if invalid value
1535+
Logger.error("Invalid identity type "+e.getMessage());
15361536
}
15371537
String existingEmail = user.getUserIdentities().get(MParticle.IdentityType.Email);
15381538
String existingHashedEmail = selectedIdentityType != null ? user.getUserIdentities().get(selectedIdentityType) : null;
@@ -1563,7 +1563,7 @@ else if (hashedEmailMismatch && existingHashedEmail != null) {
15631563
if (emailMismatch) {
15641564
identityBuilder.email(email);
15651565
}
1566-
if (hashedEmailMismatch && selectedIdentityType != null) {
1566+
if (hashedEmailMismatch) {
15671567
identityBuilder.userIdentity(selectedIdentityType, hashedEmail);
15681568
}
15691569

0 commit comments

Comments
 (0)