Skip to content

Commit eff10ea

Browse files
jamesnroktclaude
andauthored
fix(ci): pin isolated-kit gradle version to prevent 6.0.0-rc.1 pull (#714)
The isolated urbanairship-kit lint/test steps in daily.yml and the kit-compatibility test in pull-request.yml run `./gradlew` from inside the kit dir without `-Pversion=...`. The kit's standalone build.gradle defaults `project.version = '+'`, so its `com.mparticle:android-kit-plugin` dependency resolves to the highest version on Maven Central — now `6.0.0-rc.1` (published 2026-05-22), which renamed/removed kit-base symbols and broke the kit's compile. Mirror the pattern already used in the Sonatype Release job: extract the SDK version via `./gradlew -q properties` and pass it as `-Pversion=...` to every standalone kit invocation, so it resolves the freshly-published mavenLocal artifact instead of the RC. Affected steps: - lint-checks → Run Isolated Kit Lint (urbanairship-kit) - kotlin-lint-checks → Run Isolated Kit Kotlin Lint (urbanairship-kit) - update-kits → Test Isolated Kits (urbanairship-kit) - kit-compatibility-test → Run Isolated Kit Compatibility Tests (urbanairship-kit) The companion defensive fix in mparticle-android-integration-urbanairship pins the kit's standalone `project.version` to `[5.0,6.0)`. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 491f169 commit eff10ea

2 files changed

Lines changed: 16 additions & 4 deletions

File tree

.github/workflows/daily.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,9 +245,12 @@ jobs:
245245
run: ./gradlew publishReleaseLocal
246246
- name: "Run Android Kit Lint"
247247
run: ./gradlew publishReleaseLocal -c settings-kits.gradle lint
248+
- name: "Get SDK version for isolated kits"
249+
id: sdk-version
250+
run: echo "version=$(./gradlew -q properties | grep '^version:' | awk '{print $2}')" >> $GITHUB_OUTPUT
248251
- name: "Run Isolated Kit Lint (urbanairship-kit)"
249252
working-directory: kits/urbanairship-kit
250-
run: ./gradlew lint
253+
run: ./gradlew -Pversion=${{ steps.sdk-version.outputs.version }} lint
251254
- name: "Archive Test Results"
252255
uses: actions/upload-artifact@v7
253256
if: always()
@@ -284,9 +287,12 @@ jobs:
284287
run: ./gradlew publishReleaseLocal
285288
- name: "Run Android Kit Kotlin Lint"
286289
run: ./gradlew publishReleaseLocal -c settings-kits.gradle ktlintCheck
290+
- name: "Get SDK version for isolated kits"
291+
id: sdk-version
292+
run: echo "version=$(./gradlew -q properties | grep '^version:' | awk '{print $2}')" >> $GITHUB_OUTPUT
287293
- name: "Run Isolated Kit Kotlin Lint (urbanairship-kit)"
288294
working-directory: kits/urbanairship-kit
289-
run: ./gradlew ktlintCheck
295+
run: ./gradlew -Pversion=${{ steps.sdk-version.outputs.version }} ktlintCheck
290296
- name: "Archive Test Results"
291297
uses: actions/upload-artifact@v7
292298
if: always()
@@ -326,9 +332,12 @@ jobs:
326332
run: ./gradlew -PisRelease=true clean publishReleaseLocal
327333
- name: "Test Kits"
328334
run: ./gradlew -PisRelease=true clean testRelease publishReleaseLocal -c settings-kits.gradle
335+
- name: "Get SDK version for isolated kits"
336+
id: sdk-version
337+
run: echo "version=$(./gradlew -PisRelease=true -q properties | grep '^version:' | awk '{print $2}')" >> $GITHUB_OUTPUT
329338
- name: "Test Isolated Kits (urbanairship-kit)"
330339
working-directory: kits/urbanairship-kit
331-
run: ./gradlew -PisRelease=true clean testRelease publishReleaseLocal
340+
run: ./gradlew -PisRelease=true -Pversion=${{ steps.sdk-version.outputs.version }} clean testRelease publishReleaseLocal
332341

333342
semantic-release-dryrun:
334343
name: "Test Semantic Release - Dry Run"

.github/workflows/pull-request.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,9 +254,12 @@ jobs:
254254
run: ./gradlew -PisRelease=true :android-kit-base:testRelease
255255
- name: "Run Kit Release Tests and Build"
256256
run: ./gradlew -PisRelease=true -p kits testRelease -c ../settings-kits.gradle
257+
- name: "Get SDK version for isolated kits"
258+
id: sdk-version
259+
run: echo "version=$(./gradlew -PisRelease=true -q properties | grep '^version:' | awk '{print $2}')" >> $GITHUB_OUTPUT
257260
- name: "Run Isolated Kit Compatibility Tests (urbanairship-kit)"
258261
working-directory: kits/urbanairship-kit
259-
run: ./gradlew -PisRelease=true testRelease
262+
run: ./gradlew -PisRelease=true -Pversion=${{ steps.sdk-version.outputs.version }} testRelease
260263

261264
automerge-dependabot:
262265
name: "Save PR Number for Dependabot Automerge"

0 commit comments

Comments
 (0)