Skip to content

Commit f64b615

Browse files
fix branch conflict issue
1 parent 872fd64 commit f64b615

2 files changed

Lines changed: 14 additions & 13 deletions

File tree

android-kit-base/src/main/java/com/mparticle/kits/KitManagerImpl.java

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1342,16 +1342,18 @@ public void execute(String viewName,
13421342
for (KitIntegration provider : providers.values()) {
13431343
try {
13441344
if (provider instanceof KitIntegration.RoktListener && !provider.isDisabled()) {
1345+
if (attributes == null) {
1346+
attributes = new HashMap<>();
1347+
}
13451348
MParticle instance = MParticle.getInstance();
13461349
MParticleUser user = instance.Identity().getCurrentUser();
1347-
String email = attributes != null ? attributes.get("email") : null;
1350+
String email = attributes.get("email");
1351+
Map<String, String> finalAttributes = attributes;
13481352
confirmEmail(email,user,instance.Identity(), () -> {
13491353
JSONArray jsonArray = new JSONArray();
13501354

13511355
KitConfiguration kitConfig = provider.getConfiguration();
1352-
if (attributes == null) {
1353-
attributes = new HashMap<>();
1354-
}
1356+
13551357
if (kitConfig != null) {
13561358
try {
13571359
jsonArray = kitConfig.getPlacementAttributesMapping();
@@ -1364,27 +1366,27 @@ public void execute(String viewName,
13641366
if (obj == null) continue;
13651367
String mapFrom = obj.optString("map");
13661368
String mapTo = obj.optString("value");
1367-
if (attributes.containsKey(mapFrom)) {
1368-
String value = attributes.remove(mapFrom);
1369-
attributes.put(mapTo, value);
1369+
if (finalAttributes.containsKey(mapFrom)) {
1370+
String value = finalAttributes.remove(mapFrom);
1371+
finalAttributes.put(mapTo, value);
13701372
}
13711373
}
13721374
Map<String, Object> objectAttributes = new HashMap<>();
1373-
for (Map.Entry<String, String> entry : attributes.entrySet()) {
1374-
if(!attributes.containsKey(Constants.MessageKey.SANDBOX_MODE_ROKT)) {
1375+
for (Map.Entry<String, String> entry : finalAttributes.entrySet()) {
1376+
if(!finalAttributes.containsKey(Constants.MessageKey.SANDBOX_MODE_ROKT)) {
13751377
objectAttributes.put(entry.getKey(), entry.getValue());
13761378
}
13771379
}
13781380
if (user != null) {
13791381
user.setUserAttributes(objectAttributes);
13801382
}
13811383

1382-
if (!attributes.containsKey(Constants.MessageKey.SANDBOX_MODE_ROKT)) {
1383-
attributes.put(Constants.MessageKey.SANDBOX_MODE_ROKT, String.valueOf(Objects.toString(MPUtility.isDevEnv(), "false"))); // Default value is "false" if null
1384+
if (!finalAttributes.containsKey(Constants.MessageKey.SANDBOX_MODE_ROKT)) {
1385+
finalAttributes.put(Constants.MessageKey.SANDBOX_MODE_ROKT, String.valueOf(Objects.toString(MPUtility.isDevEnv(), "false"))); // Default value is "false" if null
13841386
}
13851387

13861388
((KitIntegration.RoktListener) provider).execute(viewName,
1387-
attributes,
1389+
finalAttributes,
13881390
mpRoktEventCallback,
13891391
placeHolders,
13901392
fontTypefaces,

android-kit-base/src/test/kotlin/com/mparticle/kits/KitManagerImplTest.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ import org.junit.Test
3636
import org.junit.runner.RunWith
3737
import org.mockito.Mockito
3838
import org.mockito.ArgumentMatchers.any
39-
import org.mockito.Mockito
4039
import org.mockito.Mockito.mock
4140
import org.mockito.Mockito.verify
4241
import org.mockito.Mockito.`when`

0 commit comments

Comments
 (0)