feat: Add sandbox mode to attributes by Mansi-mParticle · Pull Request #559 · mParticle/mparticle-android-sdk

Mansi-mParticle · 2025-04-10T19:10:01Z

Instructions

PR target branch should be against development
PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Added logic to include the sandbox mode flag in the attributes map. This flag is only added if it's not already present, with a default value of "false" when the environment value is null.

Testing Plan

Was this tested locally? If not, explain why.
Tested With sample app and executed test cases

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Closes https://go.mparticle.com/work/SQDSDKS-7206

rmi22186

Please add tests for the following cases:
Can you add a test case for:

mock the environment and doesn't pass a sandbox attribute to ensure the environment variable is being used
mock the environment as development, but passes sandbox attribute as false and ensure false is set on selectPlacements

rmi22186

this looks good. can you add tests first though?

rmi22186 · 2025-04-30T18:42:09Z

@Mansi-mParticle looks like this needs to be properly rebased. it has too many commits in it. then you still need to add tests

BrandonStalnaker

Logic looks good/matches iOS. Had one small question/suggestion on the code but good otherwise

BrandonStalnaker · 2025-06-02T13:04:17Z

+                        }
+                    }
+                    if (user != null) {
+                        user.setUserAttributes(objectAttributes);


The logic here seems a little convoluted to me. Why are we making and updating this new variable objectAttributes ? Could you just

if (user != null) { user.setUserAttributes(objectAttributes); }

on line 1376 in the if where you confirm its not sandbox mode? Oh maybe there's not a setUserAttribute method? ( a method to set them one at a time)

We only need the attributes except the one for sandbox mode, so objectAttributes should not include the sandbox mode attribute.

@nonnull

## [5.65.0](v5.64.0...v5.65.0) (2025-06-09) ### Features * Add sandbox mode to attributes ([#559](#559)) ([cbccd13](cbccd13)) ### Bug Fixes * Add @nonnull and @nullable annotations to execute method parameters ([#579](#579)) ([9089098](9089098)) * add Rokt dimensions layout to show embedded placements correctly ([#580](#580)) ([9d6813c](9d6813c)) ### Updates & Maintenance * Update submodules ([4ed38b5](4ed38b5))

mparticle-automation · 2025-06-09T23:55:11Z

🎉 This PR is included in version 5.65.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Mansi-mParticle requested review from BrandonStalnaker, alexs-mparticle and rmi22186 April 10, 2025 19:10

rmi22186 requested changes Apr 10, 2025

View reviewed changes

Comment thread android-kit-base/src/main/java/com/mparticle/kits/KitManagerImpl.java Outdated

Mansi-mParticle requested a review from rmi22186 April 10, 2025 21:35

rmi22186 reviewed Apr 11, 2025

View reviewed changes

Mansi-mParticle force-pushed the development branch 3 times, most recently from 73f2388 to 5910509 Compare April 11, 2025 19:44

Mansi-mParticle force-pushed the feat/SQDSDKS-7206-sandbox-mode branch from 7e0d142 to fddaefd Compare May 1, 2025 16:26

Mansi-mParticle requested a review from rmi22186 May 1, 2025 19:43

rmi22186 reviewed May 8, 2025

View reviewed changes

Comment thread android-core/src/main/kotlin/com/mparticle/internal/Constants.kt Outdated

Mansi-mParticle force-pushed the feat/SQDSDKS-7206-sandbox-mode branch from 9c9ed4d to 8ce20c6 Compare May 12, 2025 21:22