Skip to content

fix: Add @NonNull and @Nullable annotations to execute method parameters #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mansi-mParticle merged 2 commits into from
Jun 9, 2025
Merged

fix: Add @NonNull and @Nullable annotations to execute method parameters #579

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5c4a7f
fix: Add @NonNull and @Nullable annotations to execute method paramters
Mansi-mParticle Jun 5, 2025
382fd13
Merge branch 'development' into fix/annotation_for_execute_method
Mansi-mParticle Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions android-core/src/main/java/com/mparticle/MParticle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,11 +1875,12 @@ public class Rokt{
protected Rokt(){

}
public void selectPlacements(String viewName,
Map<String, String> attributes,
MpRoktEventCallback callbacks,
Map<String, WeakReference<RoktEmbeddedView>> placeHolders,
Map<String, WeakReference<Typeface>> fontTypefaces) {

public void selectPlacements(@NonNull String viewName,
@NonNull Map<String, String> attributes,
@Nullable MpRoktEventCallback callbacks,
@Nullable Map<String, WeakReference<RoktEmbeddedView>> placeHolders,
@Nullable Map<String, WeakReference<Typeface>> fontTypefaces) {
if (mConfigManager.isEnabled()) {
mKitManager.execute(viewName,
attributes,
Expand All @@ -1888,8 +1889,8 @@ public void selectPlacements(String viewName,
fontTypefaces);
}
}
public void selectPlacements(String viewName,
Map<String, String> attributes) {
public void selectPlacements(@NonNull String viewName,
@NonNull Map<String, String> attributes) {
if (mConfigManager.isEnabled()) {
mKitManager.execute(viewName,
attributes,
Expand Down
Loading