Skip to content

feat: Always set the wrapperSdkVersion in KitManager #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesnrokt merged 1 commit into from
Jun 17, 2025
Merged

feat: Always set the wrapperSdkVersion in KitManager #584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion android-core/src/main/java/com/mparticle/MParticle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,12 +385,14 @@ public WrapperSdkVersion getWrapperSdkVersion() {
* @param version
*/
public void setWrapperSdk(@NotNull WrapperSdk wrapperSdk, @NotNull String version) {
// Set instance wrapperSdkVersion if it is not set or if the wrapperSdk is different from the current one
if (this.wrapperSdkVersion.getSdk() == WrapperSdk.WrapperNone && (wrapperSdk != WrapperSdk.WrapperNone && !version.isEmpty())) {
this.wrapperSdkVersion = new WrapperSdkVersion(wrapperSdk, version);
}

if (mConfigManager.isEnabled()) {
mKitManager.setWrapperSdkVersion(wrapperSdkVersion);
// Regardless of instance wrapperSdkVersion, set the wrapperSdkVersion in KitManager
mKitManager.setWrapperSdkVersion(new WrapperSdkVersion(wrapperSdk, version));
}
}

Expand Down
Loading