Skip to content

fix: ensure user attributes are applied before proceeding with Rokt execution #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mansi-mParticle merged 1 commit into from
Jun 17, 2025
Merged

fix: ensure user attributes are applied before proceeding with Rokt execution #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 40 additions & 20 deletions android-kit-base/src/main/java/com/mparticle/kits/KitManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import com.mparticle.MParticle;
import com.mparticle.MParticleOptions;
import com.mparticle.MParticleTask;
import com.mparticle.TypedUserAttributeListener;
import com.mparticle.UserAttributeListener;
import com.mparticle.WrapperSdkVersion;
import com.mparticle.commerce.CommerceEvent;
Expand Down Expand Up @@ -1369,27 +1370,21 @@ public void execute(@NonNull String viewName,
finalAttributes.put(mapTo, value);
}
}
Map<String, Object> objectAttributes = new HashMap<>();
for (Map.Entry<String, String> entry : finalAttributes.entrySet()) {
if(!entry.getKey().equals(Constants.MessageKey.SANDBOX_MODE_ROKT)) {
objectAttributes.put(entry.getKey(), entry.getValue());
}
}
if (user != null) {
user.setUserAttributes(objectAttributes);
}

if (!finalAttributes.containsKey(Constants.MessageKey.SANDBOX_MODE_ROKT)) {
finalAttributes.put(Constants.MessageKey.SANDBOX_MODE_ROKT, String.valueOf(Objects.toString(MPUtility.isDevEnv(), "false"))); // Default value is "false" if null
}
setRoktAttributesOnUser(finalAttributes, user, () -> {
if (!finalAttributes.containsKey(Constants.MessageKey.SANDBOX_MODE_ROKT)) {
finalAttributes.put(Constants.MessageKey.SANDBOX_MODE_ROKT, String.valueOf(Objects.toString(MPUtility.isDevEnv(), "false"))); // Default value is "false" if null
}

((KitIntegration.RoktListener) provider).execute(viewName,
finalAttributes,
mpRoktEventCallback,
placeHolders,
fontTypefaces,
FilteredMParticleUser.getInstance(user.getId(), provider),
config);
Long userId = (user != null) ? user.getId() : null;
FilteredMParticleUser filteredUser = FilteredMParticleUser.getInstance(userId, provider);
((KitIntegration.RoktListener) provider).execute(viewName,
finalAttributes,
mpRoktEventCallback,
placeHolders,
fontTypefaces,
filteredUser,
config);
Comment thread
rmi22186 marked this conversation as resolved.
});
});
}
} catch (Exception e) {
Expand Down Expand Up @@ -1424,6 +1419,31 @@ public void purchaseFinalized(@NonNull String placementId, @NonNull String catal
}
}

private void setRoktAttributesOnUser(
Map<String, String> finalAttributes,
MParticleUser user,
Runnable runnable
) {
Map<String, Object> objectAttributes = new HashMap<>();
for (Map.Entry<String, String> entry : finalAttributes.entrySet()) {
if(!entry.getKey().equals(Constants.MessageKey.SANDBOX_MODE_ROKT)) {
objectAttributes.put(entry.getKey(), entry.getValue());
}
}
if (user != null) {
user.setUserAttributes(objectAttributes);
// Use asynchronous getUserAttributes with callback to ensure attributes are set before proceeding
user.getUserAttributes(new TypedUserAttributeListener() {
@Override
public void onUserAttributesReceived(@NonNull Map<String, ?> userAttributes, @NonNull Map<String, ? extends List<String>> userAttributeLists, long mpid) {
runnable.run();
}
});
} else {
runnable.run();
}
}

private void confirmEmail(
@Nullable String email,
@Nullable MParticleUser user,
Expand Down
Loading