fix: Restore ProGuard rules to preserve Rokt class members#590
Merged
Conversation
jamesnrokt
reviewed
Jun 24, 2025
jamesnrokt
approved these changes
Jun 24, 2025
thomson-t
force-pushed
the
fix/rokt-events-api-proguard
branch
2 times, most recently
from
2976209 to
eca3f9d
Compare
`events` API from Rokt class was getting removed by proguard. Keep the class members and annotations for kotlin metadata Co-authored-by: James Newman <james.newman@rokt.com> Signed-off-by: Thomson Thomas <125323226+thomson-t@users.noreply.github.com>
thomson-t
force-pushed
the
fix/rokt-events-api-proguard
branch
from
eca3f9d to
3a941ec
Compare
mparticle-automation
added a commit
that referenced
this pull request
Jun 24, 2025
Collaborator
|
🎉 This PR is included in version 5.70.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
eventsAPI from Rokt class was getting removed by proguard. Keep the class members and annotations for kotlin metadataTesting Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)