Skip to content

fix: Refactor InstallReferrerClient to use reflection#592

Merged
Mansi-mParticle merged 2 commits into
developmentfrom
feat/SQDSDKS-7474-InstallReferrerClient-crash
Jul 3, 2025
Merged

fix: Refactor InstallReferrerClient to use reflection#592
Mansi-mParticle merged 2 commits into
developmentfrom
feat/SQDSDKS-7474-InstallReferrerClient-crash

Conversation

@jamesnrokt

Copy link
Copy Markdown
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Fixes a fatal crash on applications built with frameworks like .NET MAUI. The crash is a NoClassDefFoundError that occurs when the InstallReferrerHelper class is accessed.
NoClassDefFoundError: Failed resolution of: Lcom/android/installreferrer/api/InstallReferrerClient;
    at com.mparticle.InstallReferrerHelper$1.run(InstallReferrerHelper.java:49)

Testing Plan

  • Was this tested locally? If not, explain why.
  • Used sample app to ensure that install receiver was provided. Received utm_source=google-play&utm_medium=organic

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@jamesnrokt jamesnrokt requested a review from a team as a code owner July 1, 2025 05:09
thomson-t
thomson-t previously approved these changes Jul 1, 2025
Comment thread android-core/src/main/java/com/mparticle/InstallReferrerHelper.java
@jamesnrokt jamesnrokt marked this pull request as draft July 2, 2025 06:32
@jamesnrokt jamesnrokt force-pushed the feat/SQDSDKS-7474-InstallReferrerClient-crash branch from 605b4eb to bf58a5e Compare July 3, 2025 02:50
@jamesnrokt jamesnrokt requested a review from a team July 3, 2025 02:59
@jamesnrokt jamesnrokt marked this pull request as ready for review July 3, 2025 02:59

@Mansi-mParticle Mansi-mParticle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mansi-mParticle Mansi-mParticle merged commit 2d00a6d into development Jul 3, 2025
21 of 23 checks passed
@Mansi-mParticle Mansi-mParticle deleted the feat/SQDSDKS-7474-InstallReferrerClient-crash branch July 3, 2025 14:53
mparticle-automation added a commit that referenced this pull request Jul 3, 2025
## [5.70.3](v5.70.2...v5.70.3) (2025-07-03)

### Bug Fixes

* Refactor InstallReferrerClient to use reflection ([#592](#592)) ([2d00a6d](2d00a6d))
@mparticle-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.70.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Jul 7, 2025
## [5.70.3](v5.70.2...v5.70.3) (2025-07-07)

### Bug Fixes

* Refactor InstallReferrerClient to use reflection ([#592](#592)) ([2d00a6d](2d00a6d))

### Updates & Maintenance

* Migrate from OSSRH to Central Publishing Portal ([#594](#594)) ([c3eb8bf](c3eb8bf))
* Update GitHub Actions workflow ([#593](#593)) ([48b546b](48b546b))
@mparticle-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.70.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Jul 7, 2025
## [5.70.3](v5.70.2...v5.70.3) (2025-07-07)

### Bug Fixes

* Refactor InstallReferrerClient to use reflection ([#592](#592)) ([2d00a6d](2d00a6d))

### Updates & Maintenance

* Migrate from OSSRH to Central Publishing Portal ([#594](#594)) ([c3eb8bf](c3eb8bf))
* Update GitHub Actions workflow ([#593](#593)) ([48b546b](48b546b))
@mparticle-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.70.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Jul 8, 2025
## [5.70.3](v5.70.2...v5.70.3) (2025-07-08)

### Bug Fixes

* Refactor InstallReferrerClient to use reflection ([#592](#592)) ([2d00a6d](2d00a6d))

### Updates & Maintenance

* Migrate from OSSRH to Central Publishing Portal ([#594](#594)) ([c3eb8bf](c3eb8bf))
* Update GitHub Actions workflow ([#593](#593)) ([48b546b](48b546b))
@mparticle-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.70.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Jul 8, 2025
## [5.70.3](v5.70.2...v5.70.3) (2025-07-08)

### Bug Fixes

* Refactor InstallReferrerClient to use reflection ([#592](#592)) ([2d00a6d](2d00a6d))

### Updates & Maintenance

* Migrate from OSSRH to Central Publishing Portal ([#594](#594)) ([c3eb8bf](c3eb8bf))
* Update GitHub Actions workflow ([#593](#593)) ([48b546b](48b546b))
* Update kit plugin publishing URL from OSSRH to CPP ([#595](#595)) ([bc546ea](bc546ea))
@mparticle-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.70.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Jul 9, 2025
## [5.70.3](v5.70.2...v5.70.3) (2025-07-09)

### Bug Fixes

* Refactor InstallReferrerClient to use reflection ([#592](#592)) ([2d00a6d](2d00a6d))

### Updates & Maintenance

* 5.70.3 (release) ([a7ad111](a7ad111)), closes [#592](#592) [#594](#594) [#593](#593) [#595](#595)
* Migrate from OSSRH to Central Publishing Portal ([#594](#594)) ([c3eb8bf](c3eb8bf))
* Update GitHub Actions workflow ([#593](#593)) ([48b546b](48b546b))
* Update kit plugin publishing URL from OSSRH to CPP ([#595](#595)) ([bc546ea](bc546ea))
* Update submodules ([8a7c97c](8a7c97c))
@mparticle-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.70.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants