Skip to content

fix: Print domain mapping logs only once per session #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mansi-mParticle merged 2 commits into from
Jul 30, 2025
Merged

fix: Print domain mapping logs only once per session #598

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abdacb4
fix: Print domain mapping logs only once per session
Mansi-mParticle Jul 24, 2025
b10f277
fix error message printing
Mansi-mParticle Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions android-core/src/main/java/com/mparticle/networking/NetworkOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,15 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.HashSet;
import java.util.Set;

public class NetworkOptions {

Map<Endpoint, DomainMapping> domainMappings = new HashMap<Endpoint, DomainMapping>();
boolean pinningDisabledInDevelopment = false;
boolean pinningDisabled = false;
private static Set<Endpoint> loggedDomainTypes = new HashSet<>();

private NetworkOptions() {
}
Expand Down Expand Up @@ -144,10 +147,13 @@ public Builder addDomainMapping(@Nullable DomainMapping domain) {
domainMappings = new HashMap<Endpoint, DomainMapping>();
}
if (domainMappings.containsKey(domain.getType())) {
try {
Logger.warning("Duplicate DomainMapping submitted, DomainMapping:\n" + domain.toJson().toString(4) + "\n will overwrite DomainMapping:\n" + domain.toJson().toString(4));
} catch (JSONException e) {
e.printStackTrace();
if (!loggedDomainTypes.contains(domain.getType())) {
try {
Logger.warning("Duplicate DomainMapping submitted, DomainMapping:\n" + domain.toJson().toString(4) + "\n will overwrite DomainMapping:\n" + domain.toJson().toString(4));
loggedDomainTypes.add(domain.getType());
} catch (JSONException e) {
e.printStackTrace();
Comment thread
Mansi-mParticle marked this conversation as resolved.
Outdated
}
}
}
if (domain.getType() == EVENTS && !domain.isEventsOnly() && !domainMappings.containsKey(ALIAS)) {
Expand Down
Loading