Skip to content

fix: Support mutable and immutable attributes in selectPlacement#602

Merged
Mansi-mParticle merged 1 commit into
developmentfrom
fix/SDKE-134-support-mutable-immutable-attributes
Sep 9, 2025
Merged

fix: Support mutable and immutable attributes in selectPlacement#602
Mansi-mParticle merged 1 commit into
developmentfrom
fix/SDKE-134-support-mutable-immutable-attributes

Conversation

@Mansi-mParticle

Copy link
Copy Markdown
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Previously, selectPlacement assumed attributes were always mutable. When an immutable map was passed, it caused issues if modifications were required during processing.Created a shallow copy of attributes before passing it to execute.This ensures compatibility with both immutable and mutable inputs.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample app for both immutable and mutable inputs.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle requested a review from a team as a code owner September 5, 2025 13:57
@sonarqubecloud

sonarqubecloud Bot commented Sep 5, 2025

Copy link
Copy Markdown

@Mansi-mParticle Mansi-mParticle merged commit 9958327 into development Sep 9, 2025
13 of 16 checks passed
@Mansi-mParticle Mansi-mParticle deleted the fix/SDKE-134-support-mutable-immutable-attributes branch September 9, 2025 15:30
mparticle-automation added a commit that referenced this pull request Sep 9, 2025
## [5.73.2](v5.73.1...v5.73.2) (2025-09-09)

### Bug Fixes

* Support mutable and immutable attributes in selectPlacement ([#602](#602)) ([9958327](9958327))

### Updates & Maintenance

* Update submodules ([6ef9b59](6ef9b59))
@mparticle-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.73.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants