Skip to content

feat: Implement Trunk tool#604

Merged
Mansi-mParticle merged 24 commits into
mainfrom
feat/add-trunk-tool
Nov 7, 2025
Merged

feat: Implement Trunk tool#604
Mansi-mParticle merged 24 commits into
mainfrom
feat/add-trunk-tool

Conversation

@Mansi-mParticle

Copy link
Copy Markdown
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Added .trunk/trunk.yaml configuration for linting and formatting tools.

Testing Plan

  • Was this tested locally? If not, explain why.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle requested a review from a team as a code owner September 12, 2025 21:26
Comment thread .github/workflows/daily.yml Outdated
Comment thread .trunk/trunk.yaml Outdated
Comment thread .trunk/trunk.yaml Outdated
Comment thread build.gradle Outdated
ktlint {
// Disable problematic rules
disabledRules = [
"trailing-comma",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we disable this? I can see it auto-formatted most of the files.

Comment thread build.gradle Outdated
"trailing-comma",
"trailing-comma-on-call-site",
"trailing-comma-on-declaration-site",
"max-line-length", // Disable line length checks

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can create a .editorconfig file with the required line length, and it should be automatically updated.

@sonarqubecloud

Copy link
Copy Markdown

@Mansi-mParticle Mansi-mParticle changed the base branch from development to main November 4, 2025 19:49
thomson-t
thomson-t previously approved these changes Nov 5, 2025

@thomson-t thomson-t left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the commit hash in kits/rokt-kit has changed. Is that intentional?

Comment thread .github/workflows/pull-request.yml
@sonarqubecloud

sonarqubecloud Bot commented Nov 7, 2025

Copy link
Copy Markdown

@Mansi-mParticle Mansi-mParticle merged commit d02a125 into main Nov 7, 2025
2 checks passed
@Mansi-mParticle Mansi-mParticle deleted the feat/add-trunk-tool branch November 7, 2025 19:20
mparticle-automation added a commit that referenced this pull request Nov 20, 2025
## [5.75.0](v5.74.3...v5.75.0) (2025-11-20)

### Features

* Implement Trunk tool ([#604](#604)) ([d02a125](d02a125))

### Updates & Maintenance

* add token to checkout step for regression branch pushes ([#627](#627)) ([afe965e](afe965e))
* bump andymckay/cancel-action from 435124153eb37d6a62a29d053a7e449652f89d51 to a955d435292c0d409d104b57d8e78435a93a6ef1 ([#624](#624)) ([2f1644a](2f1644a))
* bump reactivecircus/android-emulator-runner from 2.34.0 to 2.35.0 ([#626](#626)) ([8f4b392](8f4b392))
* update permissions to allow branch push and delete operations ([#628](#628)) ([d66079d](d66079d))
@mparticle-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.75.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants