feat: migrate appsflyer-kit from submodule to regular directory#650
Merged
Conversation
Made-with: Cursor
|
thomson-t
approved these changes
Mar 5, 2026
Collaborator
There was a problem hiding this comment.
I think this is being used. Can we remove this, or capture this as a todo item to remove?
| - gradlew | ||
| - "**/gradlew" | ||
| - scripts/install-start-emulator.sh | ||
| - kits/appsflyer/appsflyer-6/** |
Collaborator
There was a problem hiding this comment.
Please add a TODO item for the trunk bypasses we are making.
There was a problem hiding this comment.
@thomson-t Added it to the cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Migrates AppsFlyer kit from git submodule to a regular directory in the main repo. The kit is relocated to
kits/appsflyer/appsflyer-6to support versioned kit structure (6 = major version of af-android-sdk).What Has Changed
kits/appsflyer/appsflyer-6settings-kits.gradleto reference new path (:kits:appsflyer:appsflyer-6).gitmodulesChecklist