refactor: Rename 'placements' to 'embeddedViews' in selectPlacements method and update related references

Author: thomson-t

.gitignore

@@ -3,6 +3,7 @@
 
 # Xcode
 build/
+.build/
 *.pbxuser
 !default.pbxuser
 *.mode1v3

Example/mParticleExample/ViewController.m

@@ -204,7 +204,7 @@ - (void)selectDarkOverlayPlacement {
     roktConfig.colorMode = MPColorModeDark;
     [[MParticle sharedInstance].rokt selectPlacements:@"RoktLayout"
                                            attributes:customAttributes
-                                           placements:nil
+                                        embeddedViews:nil
                                                config:roktConfig
                                             callbacks:nil];
 }
@@ -235,9 +235,9 @@ - (void)selectEmbeddedPlacement {
         [self setupUI:size];
     };
 
-    NSDictionary *placements = @{@"Location1": self.roktView};
+    NSDictionary *embeddedViews = @{@"Location1": self.roktView};
 
-    [[MParticle sharedInstance].rokt selectPlacements:@"testiOS" attributes:customAttributes placements:placements config:nil callbacks:callbacks];
+    [[MParticle sharedInstance].rokt selectPlacements:@"testiOS" attributes:customAttributes embeddedViews:embeddedViews config:nil callbacks:callbacks];
 }
 
 - (void)getAudience {

UnitTests/MPRoktTests.m

@@ -124,7 +124,7 @@ - (void)testSelectPlacementsExpandedWithValidParameters {
     NSDictionary *attributes = @{@"key": @"value"};
     NSDictionary *finalAttributes = @{@"key": @"value", @"sandbox": @"true"};
     MPRoktEmbeddedView *exampleView = [[MPRoktEmbeddedView alloc] initWithFrame:CGRectZero];
-    NSDictionary *placements = @{@"placement": exampleView};
+    NSDictionary *embeddedViews = @{@"placement": exampleView};
     MPRoktEventCallback *exampleCallbacks = [[MPRoktEventCallback alloc] init];
     exampleCallbacks.onLoad = ^{};
     exampleCallbacks.onUnLoad = ^{};
@@ -145,7 +145,7 @@ - (void)testSelectPlacementsExpandedWithValidParameters {
                                  parameters:[OCMArg checkWithBlock:^BOOL(MPForwardQueueParameters *params) {
         XCTAssertEqualObjects(params[0], viewName);
         XCTAssertEqualObjects(params[1], finalAttributes);
-        XCTAssertEqualObjects(params[2], placements);
+        XCTAssertEqualObjects(params[2], embeddedViews);
         XCTAssertEqualObjects(params[3], roktConfig);
         MPRoktEventCallback *resultCallbacks = params[4];
         XCTAssertEqualObjects(resultCallbacks.onLoad, exampleCallbacks.onLoad);
@@ -163,7 +163,7 @@ - (void)testSelectPlacementsExpandedWithValidParameters {
     // Execute method
     [self.rokt selectPlacements:viewName
                      attributes:attributes
-                     placements:placements
+                  embeddedViews:embeddedViews
                          config:roktConfig
                       callbacks:exampleCallbacks];
 
@@ -188,7 +188,7 @@ - (void)testSelectPlacementsExpandedWithNilParameters {
     // Execute method with nil parameters
     [self.rokt selectPlacements:viewName
                      attributes:nil
-                     placements:nil
+                  embeddedViews:nil
                          config:nil
                       callbacks:nil];
 

mParticle-Apple-SDK/Include/MPRokt.h

@@ -76,12 +76,12 @@ typedef NS_ENUM(NSInteger, MPColorMode) {
  *
  * @param identifier Unique identifier for the placement
  * @param attributes Optional dictionary of attributes to customize the placement
- * @param placements Optional dictionary mapping placement names to their embedded views
+ * @param embeddedViews Optional dictionary mapping placement names to their embedded views
  * @param roktEventCallback Optional callback object to handle widget events
  */
 - (void)selectPlacements:(NSString *_Nonnull)identifier
               attributes:(NSDictionary<NSString *, NSString *> * _Nullable)attributes
-              placements:(NSDictionary<NSString *, MPRoktEmbeddedView *> * _Nullable)placements
+           embeddedViews:(NSDictionary<NSString *, MPRoktEmbeddedView *> * _Nullable)embeddedViews
                   config:(MPRoktConfig * _Nullable)config
                callbacks:(MPRoktEventCallback * _Nullable)roktEventCallback;
 

mParticle-Apple-SDK/MPRokt.m

@@ -24,12 +24,12 @@ @implementation MPRokt
 
 - (void)selectPlacements:(NSString *)identifier
               attributes:(NSDictionary<NSString *, NSString *> * _Nullable)attributes {
-    [self selectPlacements:identifier attributes:attributes placements:nil config:nil callbacks:nil];
+    [self selectPlacements:identifier attributes:attributes embeddedViews:nil config:nil callbacks:nil];
 }
 
 - (void)selectPlacements:(NSString *)identifier
               attributes:(NSDictionary<NSString *, NSString *> * _Nullable)attributes
-              placements:(NSDictionary<NSString *, MPRoktEmbeddedView *> * _Nullable)placements
+           embeddedViews:(NSDictionary<NSString *, MPRoktEmbeddedView *> * _Nullable)embeddedViews
                   config:(MPRoktConfig * _Nullable)config
                callbacks:(MPRoktEventCallback * _Nullable)callbacks {
     MParticleUser *currentUser = [MParticle sharedInstance].identity.currentUser;
@@ -62,7 +62,7 @@ - (void)selectPlacements:(NSString *)identifier
                 MPForwardQueueParameters *queueParameters = [[MPForwardQueueParameters alloc] init];
                 [queueParameters addParameter:identifier];
                 [queueParameters addParameter:[self confirmSandboxAttribute:mappedAttributes]];
-                [queueParameters addParameter:placements];
+                [queueParameters addParameter:embeddedViews];
                 [queueParameters addParameter:config];
                 [queueParameters addParameter:callbacks];