refactor: Rename 'placements' to 'embeddedViews' in selectPlacements method and update related references#368
Merged
BrandonStalnaker merged 3 commits intoJun 17, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the parameter name in the selectPlacements method to use "embeddedViews" instead of "placements" for improved clarity and consistency.
- Updated method calls and declarations in MPRokt.m and MPRokt.h
- Adjusted unit tests and example usage to use the new parameter name
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mParticle-Apple-SDK/MPRokt.m | Updated method calls and parameter naming from placements to embeddedViews |
| mParticle-Apple-SDK/Include/MPRokt.h | Modified method declaration and documentation for clarity |
| UnitTests/MPRoktTests.m | Revised unit tests to align with the new parameter naming |
| Example/mParticleExample/ViewController.m | Updated example usage to reflect the name change |
…method and update related references Rename param
3d63e8a to
dfad0a3
Compare
jamesnrokt
approved these changes
Jun 17, 2025
BrandonStalnaker
approved these changes
Jun 17, 2025
BrandonStalnaker
left a comment
Collaborator
There was a problem hiding this comment.
LGTM but since we're changing the KitProtocol as well we should make sure the corresponding change for the kit is released at the same time.
Collaborator
|
corresponding kit PR mparticle-integrations/mparticle-apple-integration-rokt#15 |
1 task
Contributor
|
🎉 This PR is included in version 8.34.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)