Skip to content

refactor: Rename 'placements' to 'embeddedViews' in selectPlacements method and update related references#368

Merged
BrandonStalnaker merged 3 commits into
developmentfrom
refactor/SQDSDKS-7419-rename-select-placement-params
Jun 17, 2025
Merged

refactor: Rename 'placements' to 'embeddedViews' in selectPlacements method and update related references#368
BrandonStalnaker merged 3 commits into
developmentfrom
refactor/SQDSDKS-7419-rename-select-placement-params

Conversation

@thomson-t

@thomson-t thomson-t commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Rename 'placements' to 'embeddedViews' in selectPlacements method

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested example app and loaded overlay and embedded placements

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the parameter name in the selectPlacements method to use "embeddedViews" instead of "placements" for improved clarity and consistency.

  • Updated method calls and declarations in MPRokt.m and MPRokt.h
  • Adjusted unit tests and example usage to use the new parameter name

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
mParticle-Apple-SDK/MPRokt.m Updated method calls and parameter naming from placements to embeddedViews
mParticle-Apple-SDK/Include/MPRokt.h Modified method declaration and documentation for clarity
UnitTests/MPRoktTests.m Revised unit tests to align with the new parameter naming
Example/mParticleExample/ViewController.m Updated example usage to reflect the name change

@thomson-t thomson-t changed the base branch from main to development June 17, 2025 03:20
…method and update related references

Rename param
@thomson-t thomson-t force-pushed the refactor/SQDSDKS-7419-rename-select-placement-params branch from 3d63e8a to dfad0a3 Compare June 17, 2025 03:27

@BrandonStalnaker BrandonStalnaker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but since we're changing the KitProtocol as well we should make sure the corresponding change for the kit is released at the same time.

@BrandonStalnaker

Copy link
Copy Markdown
Collaborator

@BrandonStalnaker BrandonStalnaker merged commit 160899a into development Jun 17, 2025
9 of 15 checks passed
@BrandonStalnaker BrandonStalnaker deleted the refactor/SQDSDKS-7419-rename-select-placement-params branch June 17, 2025 13:15
@mparticle-automation

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 8.34.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants