-
Notifications
You must be signed in to change notification settings - Fork 72
ci: add publish-cocoapods job to release-publish workflow #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nickolas-dimitrakas
merged 3 commits into
main
from
ci/publish-cocoapods-release-publish
Apr 8, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kit CocoaPods job skipped on manual non-dry-run dispatch
Medium Severity
The
if: ${{ !inputs.dry_run }}condition onpublish-kit-cocoapodsuses theinputscontext, whereworkflow_dispatchboolean inputs are strings ('true'/'false'), not actual booleans. Since'false'is a non-empty string (truthy),!'false'evaluates tofalse, causing the entire job to be silently skipped when a user manually triggers the workflow withdry_rununchecked. Every other dry-run guard in this workflow uses the reliableenv.DRY_RUN != 'true'pattern at step level, which correctly handles the string representation.Reviewed by Cursor Bugbot for commit 2d3e273. Configure here.