Skip to content

chore: clean up CocoaPods podspec source globs#724

Merged
denischilik merged 2 commits into
mainfrom
feat/clean-up-podspec
Apr 8, 2026
Merged

chore: clean up CocoaPods podspec source globs#724
denischilik merged 2 commits into
mainfrom
feat/clean-up-podspec

Conversation

@denischilik
Copy link
Copy Markdown
Contributor

Background

CocoaPods globs listed extensions that are not present in the repo; the main SDK also exposed a redundant Location-disabled subspec now that the library ships a single variant.

What Has Changed

  • mParticle-Apple-SDK.podspec: source_files limited to *.h / *.m; removed mParticleNoLocation subspec.
  • Kit podspecs: dropped unused mm from *.{h,m,mm} patterns (kits have no Objective-C++ sources).

Breaking change

Pods or apps that depend on mParticle-Apple-SDK/mParticleNoLocation must use the default mParticle subspec or mParticle-Apple-SDK without that path (e.g. update Media SDK / Iterable kit podspecs in lockstep).

Screenshots/Video

N/A

- Limit mParticle/AppExtension source_files to .h and .m (no .mm/.cpp/.swift under tree)
- Drop mParticleNoLocation subspec; SDK is single variant without Location

Made-with: Cursor
Kit sources use only .h/.m; align CocoaPods patterns with the tree.

Made-with: Cursor
@denischilik denischilik requested a review from a team as a code owner April 8, 2026 15:04
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 8, 2026

PR Summary

Medium Risk
Mostly build/packaging changes, but removing the mParticleNoLocation subspec can break consumers that reference it and narrowing source_files globs could omit sources if any non-.m files were previously relied upon.

Overview
CocoaPods podspec cleanup: Updates the main mParticle-Apple-SDK.podspec to only glob Objective-C sources (*.h, *.m) and removes the redundant mParticleNoLocation subspec.

Kit podspec tightening: Updates multiple kit podspecs to drop *.mm from source_files globs (and similarly for iOS-specific globs), aligning the specs with the actual source file types shipped.

Reviewed by Cursor Bugbot for commit 09b9c54. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.75 MB 1.75 MB +N/A
Executable Impact 848 bytes 848 bytes +N/A
XCFramework Size 6.38 MB 6.38 MB +N/A

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (main):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1880,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1796,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6532}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1880,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1796,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6532}

@denischilik denischilik merged commit 41a8153 into main Apr 8, 2026
133 of 140 checks passed
@denischilik denischilik deleted the feat/clean-up-podspec branch April 8, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants