Skip to content

Commit 15106a8

Browse files
committed
remove self=this pattern
1 parent 211fc65 commit 15106a8

1 file changed

Lines changed: 14 additions & 18 deletions

File tree

src/forwarders.ts

Lines changed: 14 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ export default function Forwarders(
4040
mpInstance: IMParticleWebSDKInstance,
4141
kitBlocker: KitBlocker
4242
): void {
43-
const self = this;
44-
4543
this.forwarderStatsUploader = new APIClient(
4644
mpInstance,
4745
kitBlocker
@@ -71,7 +69,7 @@ export default function Forwarders(
7169
});
7270

7371
mpInstance._Store.activeForwarders = mpInstance._Store.configuredForwarders.filter(
74-
function(forwarder) {
72+
(forwarder) => {
7573
if (
7674
!mpInstance._Consent.isEnabledForUserConsent(
7775
forwarder.filteringConsentRuleValues,
@@ -81,15 +79,15 @@ export default function Forwarders(
8179
return false;
8280
}
8381
if (
84-
!(self.isEnabledForUserAttributes as Function)(
82+
!(this.isEnabledForUserAttributes as Function)(
8583
forwarder.filteringUserAttributeValue,
8684
user
8785
)
8886
) {
8987
return false;
9088
}
9189
if (
92-
!(self.isEnabledForUnknownUser as Function)(
90+
!(this.isEnabledForUnknownUser as Function)(
9391
forwarder.excludeAnonymousUser,
9492
user
9593
)
@@ -543,10 +541,10 @@ export default function Forwarders(
543541
'No config was passed. Cannot process forwarders'
544542
);
545543
} else {
546-
(self.processUIEnabledKits as Function)(config);
547-
(self.processSideloadedKits as Function)(config);
544+
(this.processUIEnabledKits as Function)(config);
545+
(this.processSideloadedKits as Function)(config);
548546

549-
(self.initForwarders as Function)(
547+
(this.initForwarders as Function)(
550548
mpInstance._Store.SDKConfig.identifyRequest.userIdentities,
551549
forwardingStatsCallback
552550
);
@@ -560,12 +558,12 @@ export default function Forwarders(
560558
// if there is a match before being initialized.
561559
// Only kits that are configured properly can be active and used for kit forwarding.
562560
this.processUIEnabledKits = function(config: IConfigResponse): void {
563-
const kits = (self.returnKitConstructors as Function)() as Dictionary<RegisteredKit>;
561+
const kits = (this.returnKitConstructors as Function)() as Dictionary<RegisteredKit>;
564562

565563
try {
566564
if (Array.isArray(config.kitConfigs) && config.kitConfigs.length) {
567-
config.kitConfigs.forEach(function(kitConfig: IKitConfigs) {
568-
(self.configureUIEnabledKit as Function)(kitConfig, kits);
565+
config.kitConfigs.forEach((kitConfig: IKitConfigs) => {
566+
(this.configureUIEnabledKit as Function)(kitConfig, kits);
569567
});
570568
}
571569
} catch (e) {
@@ -626,7 +624,7 @@ export default function Forwarders(
626624
(config as IKitConfigs & { isSandbox?: boolean }).isSandbox ===
627625
mpInstance._Store.SDKConfig.isDevelopmentMode
628626
) {
629-
newKit = (self.returnConfiguredKit as Function)(kits[name], config);
627+
newKit = (this.returnConfiguredKit as Function)(kits[name], config);
630628

631629
mpInstance._Store.configuredForwarders.push(newKit);
632630
break;
@@ -673,7 +671,7 @@ export default function Forwarders(
673671
for (const registeredKitKey in registeredSideloadedKits.kits) {
674672
const registeredKit =
675673
registeredSideloadedKits.kits[registeredKitKey];
676-
(self.configureSideloadedKit as Function)(registeredKit);
674+
(this.configureSideloadedKit as Function)(registeredKit);
677675
}
678676

679677
// If Sideloaded Kits are successfully registered,
@@ -696,7 +694,7 @@ export default function Forwarders(
696694
kitConstructor: RegisteredKit
697695
): void {
698696
mpInstance._Store.configuredForwarders.push(
699-
(self.returnConfiguredKit as Function)(kitConstructor, kitConstructor.filters)
697+
(this.returnConfiguredKit as Function)(kitConstructor, kitConstructor.filters)
700698
);
701699
};
702700

@@ -753,10 +751,8 @@ export default function Forwarders(
753751
this.processPixelConfigs = function(config: IConfigResponse): void {
754752
try {
755753
if (!isEmpty(config.pixelConfigs)) {
756-
config.pixelConfigs.forEach(function(
757-
pixelConfig: IPixelConfiguration
758-
) {
759-
(self.configurePixel as Function)(pixelConfig);
754+
config.pixelConfigs.forEach((pixelConfig: IPixelConfiguration) => {
755+
(this.configurePixel as Function)(pixelConfig);
760756
});
761757
}
762758
} catch (e) {

0 commit comments

Comments
 (0)