Skip to content

Commit 338cc8b

Browse files
committed
fix: use getHref() for page_url capture and drop generated .d.ts edits
1 parent 8f5a180 commit 338cc8b

4 files changed

Lines changed: 4 additions & 6 deletions

File tree

dist/types/src/kitBlocking.d.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ export default class KitBlocker {
6666
LaunchReferral?: string;
6767
ExpandedEventCount: number;
6868
ActiveTimeOnSite: number;
69-
PageUrl?: string;
7069
IsBackgroundAST?: boolean;
7170
AlreadySentToForwarders?: boolean;
7271
};
@@ -111,7 +110,6 @@ export default class KitBlocker {
111110
LaunchReferral?: string;
112111
ExpandedEventCount: number;
113112
ActiveTimeOnSite: number;
114-
PageUrl?: string;
115113
IsBackgroundAST?: boolean;
116114
AlreadySentToForwarders?: boolean;
117115
};

dist/types/src/sdkRuntimeModels.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ export interface SDKEvent {
6060
LaunchReferral?: string;
6161
ExpandedEventCount: number;
6262
ActiveTimeOnSite: number;
63-
PageUrl?: string;
6463
IsBackgroundAST?: boolean;
6564
AlreadySentToForwarders?: boolean;
6665
}

src/batchUploader.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import Constants from './constants';
33
import { SDKEvent, SDKEventCustomFlags } from './sdkRuntimeModels';
44
import { convertEvents } from './sdkToEventsApiConverter';
55
import { MessageType, EventType } from './types';
6-
import { getRampNumber, isEmpty, obfuscateDevData } from './utils';
6+
import { getRampNumber, getHref, isEmpty, obfuscateDevData } from './utils';
77
import { SessionStorageVault, LocalStorageVault } from './vault';
88
import {
99
AsyncUploader,
@@ -193,7 +193,7 @@ export class BatchUploader {
193193
SessionStartDate: sessionStartDate?.getTime() || now,
194194
Debug: SDKConfig.isDevelopmentMode,
195195
ActiveTimeOnSite: _timeOnSiteTimer?.getTimeInForeground() || 0,
196-
PageUrl: window.location.href || null,
196+
PageUrl: getHref() || null,
197197
IsBackgroundAST: true
198198
} as SDKEvent;
199199

src/serverModel.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import {
1717
Dictionary,
1818
isValidCustomFlagProperty,
1919
extend,
20+
getHref,
2021
} from './utils';
2122
import { IntegrationAttributes, ServerSettings } from './store';
2223
import { MPID } from '@mparticle/web-sdk';
@@ -310,7 +311,7 @@ export default function ServerModel(
310311
event.name
311312
),
312313
ActiveTimeOnSite: mpInstance._timeOnSiteTimer?.getTimeInForeground(),
313-
PageUrl: window.location.href || null,
314+
PageUrl: getHref() || null,
314315
SourceMessageId:
315316
event.sourceMessageId ||
316317
mpInstance._Helpers.generateUniqueId(),

0 commit comments

Comments
 (0)