ci: validate generated type declarations

Author: rmi22186

.github/workflows/pull-request.yml

@@ -84,6 +84,31 @@ jobs:
                   name: npm-logs
                   path: ~/.npm/_logs
 
+    test-types:
+        name: 'Test Type Declarations'
+        runs-on: ubuntu-latest
+        steps:
+            - name: Checkout
+              uses: actions/checkout@v6
+
+            - name: NPM install
+              uses: actions/setup-node@v6
+              with:
+                  node-version: latest
+
+            - name: Run NPM CI
+              run: npm ci
+
+            - name: Build and Test Type Declarations
+              run: npm run test:types
+
+            - name: Archive npm failure logs
+              uses: actions/upload-artifact@v6
+              if: failure()
+              with:
+                  name: npm-logs
+                  path: ~/.npm/_logs
+
     # Only Core test requires bundle, but we want to make sure
     # that tests only run when the bundle is successfully built
     test-core:

.github/workflows/release.yml

@@ -79,6 +79,31 @@ jobs:
                   name: npm-logs
                   path: ~/.npm/_logs
 
+    test-types:
+        name: 'Test Type Declarations'
+        runs-on: ubuntu-latest
+        steps:
+            - name: Checkout
+              uses: actions/checkout@v6
+
+            - name: NPM install
+              uses: actions/setup-node@v6
+              with:
+                  node-version: latest
+
+            - name: Run NPM CI
+              run: npm ci
+
+            - name: Build and Test Type Declarations
+              run: npm run test:types
+
+            - name: Archive npm failure logs
+              uses: actions/upload-artifact@v6
+              if: failure()
+              with:
+                  name: npm-logs
+                  path: ~/.npm/_logs
+
     # Only Core test requires bundle, but we want to make sure
     # that tests only run when the bundle is successfully built
     test-core:
@@ -222,6 +247,7 @@ jobs:
             - test-integrations-module-js-rollup
             - test-integrations-require-js
             - confirm-public-repo-master-branch
+            - test-types
         steps:
             - name: Checkout development branch
               uses: actions/checkout@v6

.github/workflows/staging-step-1.yml

@@ -93,6 +93,31 @@ jobs:
                   name: npm-logs
                   path: ~/.npm/_logs
 
+    test-types:
+        name: 'Test Type Declarations'
+        runs-on: ubuntu-latest
+        steps:
+            - name: Checkout
+              uses: actions/checkout@v6
+
+            - name: NPM install
+              uses: actions/setup-node@v6
+              with:
+                  node-version: 24.x
+
+            - name: Run NPM CI
+              run: npm ci
+
+            - name: Build and Test Type Declarations
+              run: npm run test:types
+
+            - name: Archive npm failure logs
+              uses: actions/upload-artifact@v6
+              if: failure()
+              with:
+                  name: npm-logs
+                  path: ~/.npm/_logs
+
     # Only Core test requires bundle, but we want to make sure
     # that tests only run when the bundle is successfully built
     test-core:
@@ -236,6 +261,7 @@ jobs:
             - test-integrations-module-js-rollup
             - test-integrations-require-js
             - confirm-staging-branch
+            - test-types
         steps:
             - name: Checkout development branch
               uses: actions/checkout@v6

DEFINITELY_TYPED_DRIFT.md

@@ -29,6 +29,11 @@ native declarations without depending on `@types/mparticle__web-sdk`, while
 avoiding declarations for named runtime imports that the ESM bundle does not
 emit.
 
+The generated `dist/types` output is intentionally not part of this PR's source
+diff. CI runs `npm run test:types`, which rebuilds declaration files from source
+before compiling the consumer fixtures against the generated package entry
+points.
+
 ## Public Type Ownership
 
 - Added native public definitions for types previously supplied by

dist/mparticle.common.js

@@ -8051,16 +8051,14 @@ var mParticle = (function () {
           };
         },
         createIdentityRequest: function createIdentityRequest(identityApiData, platform, sdkVendor, sdkVersion, deviceId, context, mpid) {
-          /** @type {import('./utils').Environment} */
-          var environment = mpInstance._Store.SDKConfig.isDevelopmentMode ? Constants.Environment.Development : Constants.Environment.Production;
           var APIRequest = {
             client_sdk: {
               platform: platform,
               sdk_vendor: sdkVendor,
               sdk_version: sdkVersion
             },
             context: context,
-            environment: environment,
+            environment: mpInstance._Store.SDKConfig.isDevelopmentMode ? 'development' : 'production',
             request_id: mpInstance._Helpers.generateUniqueId(),
             request_timestamp_ms: new Date().getTime(),
             previous_mpid: mpid || null,
@@ -8069,16 +8067,14 @@ var mParticle = (function () {
           return APIRequest;
         },
         createModifyIdentityRequest: function createModifyIdentityRequest(currentUserIdentities, newUserIdentities, platform, sdkVendor, sdkVersion, context) {
-          /** @type {import('./utils').Environment} */
-          var environment = mpInstance._Store.SDKConfig.isDevelopmentMode ? Constants.Environment.Development : Constants.Environment.Production;
           return {
             client_sdk: {
               platform: platform,
               sdk_vendor: sdkVendor,
               sdk_version: sdkVersion
             },
             context: context,
-            environment: environment,
+            environment: mpInstance._Store.SDKConfig.isDevelopmentMode ? 'development' : 'production',
             request_id: mpInstance._Helpers.generateUniqueId(),
             request_timestamp_ms: new Date().getTime(),
             identity_changes: this.createIdentityChanges(currentUserIdentities, newUserIdentities)
@@ -8496,9 +8492,6 @@ var mParticle = (function () {
        * Example: mParticle.Identity.getCurrentUser().getAllUserAttributes()
        * @class mParticle.Identity.getCurrentUser()
        */
-      /**
-       * @returns {import('./identity-user-interfaces').IMParticleUser}
-       */
       this.mParticleUser = function (mpid, _isLoggedIn) {
         var self = this;
         return {
@@ -8833,9 +8826,6 @@ var mParticle = (function () {
        * @class mParticle.Identity.getCurrentUser().getCart()
        * @deprecated
        */
-      /**
-       * @returns {import('./identity-user-interfaces').mParticleUserCart}
-       */
       this.mParticleUserCart = function () {
         return {
           /**

dist/mparticle.esm.js

@@ -45,7 +45,7 @@ export interface IFilteringConsentRuleValues {
     values: IConsentRuleValue[];
 }
 export interface IConsentRuleValue {
-    consentPurpose: string | number;
+    consentPurpose: string;
     hasConsented: boolean;
 }
 export interface IConfigResponse {

dist/mparticle.js

@@ -1,4 +1,4 @@
-import { ConsentState, PrivacyConsentState } from './publicSdkTypes';
+import { ConsentState, PrivacyConsentState } from '@mparticle/web-sdk';
 import { Dictionary } from './utils';
 import { IMParticleUser } from './identity-user-interfaces';
 import { IMParticleWebSDKInstance } from './mp-instance';
@@ -51,7 +51,7 @@ export interface IConsentStateV2DTO {
     ccpa?: ICCPAConsentStateV2DTO;
 }
 export interface IConsentRulesValues {
-    consentPurpose: string | number;
+    consentPurpose: string;
     hasConsented: boolean;
 }
 export interface IConsentRules {

dist/types/src/configAPIClient.d.ts

@@ -1,5 +1,5 @@
 import { Dictionary } from './utils';
-import { MPID } from './publicSdkTypes';
+import { MPID } from '@mparticle/web-sdk';
 import { IConsentRules } from './consent';
 import { IMParticleWebSDKInstance } from './mp-instance';
 export declare const DAYS_IN_MILLISECONDS: number;