refactor: replace SDKLoggerApi with ILogger interface

Define proper ILogger and IConsoleLogger interfaces in logger.ts and
have Logger/ConsoleLogger implement them directly. SDKLoggerApi is
retained as a deprecated type alias for backwards compatibility.

Updates all consumers (audienceManager, batchUploader, roktManager)
and tests to import ILogger from logger.ts.

Author: alexs-mparticle

src/audienceManager.ts

@@ -1,4 +1,4 @@
-import { SDKLoggerApi } from './sdkRuntimeModels';
+import { ILogger } from './logger';
 import {
     FetchUploader,
     XHRUploader,
@@ -21,12 +21,12 @@ export interface IAudienceMemberships {
 export default class AudienceManager {
     public url: string = '';
     public userAudienceAPI: AsyncUploader;
-    public logger: SDKLoggerApi;
+    public logger: ILogger;
 
     constructor(
         userAudienceUrl: string,
         apiKey: string,
-        logger: SDKLoggerApi,
+        logger: ILogger,
     ) {
         this.logger = logger;
         this.url = `https://${userAudienceUrl}${apiKey}/audience`;

src/batchUploader.ts

@@ -1,6 +1,7 @@
 import { Batch } from '@mparticle/event-models';
 import Constants from './constants';
-import { SDKEvent, SDKEventCustomFlags, SDKLoggerApi } from './sdkRuntimeModels';
+import { SDKEvent, SDKEventCustomFlags } from './sdkRuntimeModels';
+import { ILogger } from './logger';
 import { convertEvents } from './sdkToEventsApiConverter';
 import { MessageType, EventType } from './types';
 import { getRampNumber, isEmpty } from './utils';
@@ -446,7 +447,7 @@ export class BatchUploader {
     // TODO: Refactor to use logger as a class method
     // https://go.mparticle.com/work/SQDSDKS-5167
     private async uploadBatches(
-        logger: SDKLoggerApi,
+        logger: ILogger,
         batches: Batch[],
         useBeacon: boolean
     ): Promise<Batch[] | null> {

src/logger.ts

@@ -1,11 +1,23 @@
-import { LogLevelType, SDKInitConfig, SDKLoggerApi } from './sdkRuntimeModels';
+import { LogLevelType, SDKInitConfig } from './sdkRuntimeModels';
 import { ReportingLogger } from './logging/reportingLogger';
 import { ErrorCodes } from './logging/types';
 
+export interface ILogger {
+    error(msg: string, code?: ErrorCodes): void;
+    verbose(msg: string): void;
+    warning(msg: string): void;
+    setLogLevel(logLevel: LogLevelType): void;
+}
+
+export interface IConsoleLogger {
+    error?(msg: string): void;
+    verbose?(msg: string): void;
+    warning?(msg: string): void;
+}
+
 export type ILoggerConfig = Pick<SDKInitConfig, 'logLevel' | 'logger'>;
-export type IConsoleLogger = Partial<Pick<SDKLoggerApi, 'error' | 'warning' | 'verbose'>>;
 
-export class Logger {
+export class Logger implements ILogger {
     private logLevel: LogLevelType;
     private logger: IConsoleLogger;
     private reportingLogger: ReportingLogger;

src/roktManager.ts

@@ -11,7 +11,7 @@ import {
     isEmpty,
 } from "./utils";
 import { SDKIdentityApi } from "./identity.interfaces";
-import { SDKLoggerApi } from "./sdkRuntimeModels";
+import { ILogger } from "./logger";
 import { IStore, LocalSessionAttributes } from "./store";
 import { UserIdentities } from "@mparticle/web-sdk";
 import { IdentityType, PerformanceMarkType } from "./types";
@@ -106,7 +106,7 @@ export default class RoktManager {
     private identityService: SDKIdentityApi;
     private store: IStore;
     private launcherOptions?: IRoktLauncherOptions;
-    private logger: SDKLoggerApi;
+    private logger: ILogger;
     private domain?: string;
     private mappedEmailShaIdentityType?: string | null;
     private captureTiming?: (metricsName: string) => void;
@@ -126,7 +126,7 @@ export default class RoktManager {
      * @param {IKitConfigs} roktConfig - Configuration object containing user attribute filters and settings
      * @param {IMParticleUser} filteredUser - User object with filtered attributes
      * @param {SDKIdentityApi} identityService - The mParticle Identity instance
-     * @param {SDKLoggerApi} logger - The mParticle Logger instance
+     * @param {ILogger} logger - The mParticle Logger instance
      * @param {IRoktOptions} options - Options for the RoktManager
      * @param {Function} captureTiming - Function to capture performance timing marks
      * 
@@ -137,7 +137,7 @@ export default class RoktManager {
         filteredUser: IMParticleUser, 
         identityService: SDKIdentityApi,
         store: IStore,
-        logger?: SDKLoggerApi,
+        logger?: ILogger,
         options?: IRoktOptions,
         captureTiming?: (metricsName: string) => void
     ): void {

src/sdkRuntimeModels.ts

@@ -50,8 +50,7 @@ import {
 } from './mp-instance';
 import Constants from './constants';
 import RoktManager, { IRoktLauncherOptions } from './roktManager';
-import { IConsoleLogger } from './logger';
-import { ErrorCodes } from './logging/types';
+import { IConsoleLogger, ILogger } from './logger';
 
 // TODO: Resolve this with version in @mparticle/web-sdk
 export type SDKEventCustomFlags = Dictionary<any>;
@@ -185,7 +184,7 @@ export interface MParticleWebSDK {
     PromotionType: typeof PromotionActionType;
     ProductActionType: typeof ProductActionType;
     Identity: SDKIdentityApi;
-    Logger: SDKLoggerApi;
+    Logger: ILogger;
     Consent: SDKConsentApi;
     _resetForTests(
         MPConfig?: SDKInitConfig,
@@ -390,12 +389,8 @@ export interface SDKHelpersApi {
     Validators: typeof Validators;
 }
 
-export interface SDKLoggerApi {
-    error(msg: string, code?: ErrorCodes): void;
-    verbose(msg: string): void;
-    warning(msg: string): void;
-    setLogLevel(logLevel: LogLevelType): void;
-}
+/** @deprecated Use {@link ILogger} from './logger' instead */
+export type SDKLoggerApi = ILogger;
 
 // TODO: Merge this with IStore in store.ts
 export interface SDKStoreApi {

test/src/tests-audience-manager.ts

@@ -3,11 +3,11 @@ import fetchMock from 'fetch-mock/esm/client';
 import { expect } from 'chai';
 import { urls, apiKey, testMPID, MPConfig } from './config/constants';
 import Constants from '../../src/constants';
-import { IMParticleInstanceManager, SDKLoggerApi } from '../../src/sdkRuntimeModels';
+import { IMParticleInstanceManager } from '../../src/sdkRuntimeModels';
 import AudienceManager, {
     IAudienceMemberships, IAudienceMembershipsServerResponse
 } from '../../src/audienceManager';
-import { Logger } from '../../src/logger';
+import { ILogger, Logger } from '../../src/logger';
 import Utils from './config/utils';
 const { fetchMockSuccess } = Utils;
 
@@ -35,7 +35,7 @@ describe('AudienceManager', () => {
 
     describe('initialization', () => {
         it('should have proper properties on AudienceManager', () => {
-            const newLogger: SDKLoggerApi = new Logger(window.mParticle.config);
+            const newLogger: ILogger = new Logger(window.mParticle.config);
             const audienceManager = new AudienceManager(
                 Constants.DefaultBaseUrls.userAudienceUrl,
                 apiKey,
@@ -49,7 +49,7 @@ describe('AudienceManager', () => {
     });
 
     describe('#sendGetUserAudienceRequest', () => {
-        let newLogger: SDKLoggerApi;
+        let newLogger: ILogger;
         let audienceManager: AudienceManager;
         beforeEach(() => {
             newLogger = new Logger(window.mParticle.config);