refactor: updated getPrivacyFlag in persistence and updated test content

Author: jaissica12

src/persistence.js

@@ -90,7 +90,7 @@ export default function _Persistence(mpInstance) {
             try {
                 if (
                     mpInstance._Store.isLocalStorageAvailable &&
-                    !mpInstance._Store.getNoTargeting()
+                    !mpInstance._Store.getPrivacyFlag('Products')
                 ) {
                     var encodedProducts = localStorage.getItem(
                         mpInstance._Store.prodStorageName
@@ -273,7 +273,7 @@ export default function _Persistence(mpInstance) {
 
     this.getUserProductsFromLS = function(mpid) {
         if (
-            mpInstance._Store.getNoTargeting() ||
+            mpInstance._Store.getPrivacyFlag('Products') ||
             !mpInstance._Store.isLocalStorageAvailable
         ) {
             return [];
@@ -314,7 +314,7 @@ export default function _Persistence(mpInstance) {
     };
 
     this.getAllUserProductsFromLS = function() {
-        if (mpInstance._Store.getNoTargeting()) {
+        if (mpInstance._Store.getPrivacyFlag('Products')) {
             var currentUser = mpInstance.Identity.getCurrentUser();
             var mpid = currentUser ? currentUser.getMPID() : null;
             var result = {};
@@ -358,14 +358,14 @@ export default function _Persistence(mpInstance) {
                     : [],
             };
 
-        if (mpInstance._Store.getNoTargeting()) {
+        if (mpInstance._Store.getPrivacyFlag('Products')) {
             return;
         }
         if (mpid) {
             allLocalStorageProducts = allLocalStorageProducts || {};
             allLocalStorageProducts[mpid] = currentUserProducts;
             try {
-                if (!mpInstance._Store.getNoTargeting()) {
+                if (!mpInstance._Store.getPrivacyFlag('Products')) {
                     window.localStorage.setItem(
                         encodeURIComponent(mpInstance._Store.prodStorageName),
                         Base64.encode(JSON.stringify(allLocalStorageProducts))
@@ -915,7 +915,7 @@ export default function _Persistence(mpInstance) {
     };
 
     this.getCartProducts = function(mpid) {
-        if (mpInstance._Store.getNoTargeting()) {
+        if (mpInstance._Store.getPrivacyFlag('Products')) {
             return [];
         }
         var allCartProducts,
@@ -938,8 +938,8 @@ export default function _Persistence(mpInstance) {
 
     this.setCartProducts = function(allProducts) {
         if (
-            !mpInstance._Store.isLocalStorageAvailable &&
-            mpInstance._Store.getNoTargeting()
+            !mpInstance._Store.isLocalStorageAvailable ||
+            mpInstance._Store.getPrivacyFlag('Products')
         ) {
             return;
         }

test/jest/persistence.spec.ts

@@ -3,31 +3,31 @@ import {
   MPConfig,
   testMPID,
 } from '../src/config/constants';
+import { Product } from '@mparticle/web-sdk';
 
 describe('Products Persistence', () => {
     let mpInstance = mParticle.getInstance();
     beforeEach(() => {
         mParticle._resetForTests(MPConfig);
     });
 
-    it('should update Products localStorage when noTargeting is false by default', () => {
+    it('should save products to localStorage when noTargeting is false by default', () => {
         const product = { Name: 'iphone', Sku: 'iphonesku', Price: 599, Quantity: 1 };
-        mpInstance._Persistence.setCartProducts({ [testMPID]: { cp: [product] } } as any);
+        mpInstance._Persistence.setCartProducts({ [testMPID]: { cp: [product] } } as unknown as Product[]);
         expect(mpInstance._Persistence.getCartProducts(testMPID).length).toBe(1);
     });
 
-    it('should NOT update Products localStorage when noTargeting is true', () => {
+    it('should NOT save products to localStorage when noTargeting is true', () => {
         mpInstance._Store.setNoTargeting(true);
         const product = { Name: 'iphone', Sku: 'iphonesku', Price: 599, Quantity: 1 };
-        mpInstance._Persistence.setCartProducts({ [testMPID]: { cp: [product] } } as any);
+        mpInstance._Persistence.setCartProducts({ [testMPID]: { cp: [product] } } as unknown as Product[]);
         expect(mpInstance._Persistence.getCartProducts(testMPID).length).toBe(0);
-        expect(mpInstance._Persistence.getCartProducts(testMPID)).toEqual([]);
     });
 
-    it('should update Products localStorage when noTargeting is false', () => {
+    it('should save products to localStorage when noTargeting is false', () => {
         mpInstance._Store.setNoTargeting(false);
         const product = { Name: 'iphone', Sku: 'iphonesku', Price: 599, Quantity: 1 };
-        mpInstance._Persistence.setCartProducts({ [testMPID]: { cp: [product] } } as any);
+        mpInstance._Persistence.setCartProducts({ [testMPID]: { cp: [product] } } as unknown as Product[]);
         expect(mpInstance._Persistence.getCartProducts(testMPID).length).toBe(1);
     });
 });

test/src/tests-persistence.ts

@@ -1666,7 +1666,7 @@ describe('persistence', () => {
             mParticle._resetForTests(MPConfig);
         }); 
 
-        it('should not save products LS when noTargeting is true', async () => {
+        it('should NOT save products to LS when noTargeting is true', async () => {
             mParticle.config.noTargeting = true;
 
             mParticle.init(apiKey, mParticle.config);
@@ -1675,7 +1675,7 @@ describe('persistence', () => {
             expect(localStorageProducts).to.not.be.ok;
         });
 
-        it('should save products LS when noTargeting is false', async () => {
+        it('should save products to LS when noTargeting is false', async () => {
             mParticle.config.noTargeting = false;
 
             mParticle.init(apiKey, mParticle.config);
@@ -1692,7 +1692,7 @@ describe('persistence', () => {
             expect(localStorageProducts).to.be.ok;
         });
 
-        it('should save products LS when noTargeting is false by default', async () => {
+        it('should save products to LS when noTargeting is false by default', async () => {
             mParticle.init(apiKey, mParticle.config);
             await waitForCondition(hasIdentifyReturned);
             const iphone = mParticle.eCommerce.createProduct(