test: updated persistence tests

Author: jaissica12

src/persistence.js

@@ -20,6 +20,9 @@ export default function _Persistence(mpInstance) {
     };
 
     this.initializeStorage = function() {
+        if (mpInstance._Store.getPrivacyFlag('SDKState')) {
+            return;
+        }
         try {
             var storage,
                 localStorageData = self.getLocalStorage(),
@@ -39,9 +42,6 @@ export default function _Persistence(mpInstance) {
             if (!mpInstance._Store.isLocalStorageAvailable) {
                 mpInstance._Store.SDKConfig.useCookieStorage = true;
             }
-            if (mpInstance._Store.getPrivacyFlag('SDKState')) {
-                return;
-            }
 
             // https://go.mparticle.com/work/SQDSDKS-6046
             if (mpInstance._Store.isLocalStorageAvailable) {

test/jest/persistence.spec.ts

@@ -2,16 +2,14 @@ import Store, { IStore } from '../../src/store';
 import { IMParticleWebSDKInstance } from '../../src/mp-instance';
 import { SDKInitConfig } from '../../src/sdkRuntimeModels';
 
-describe('Persistence store', () => {
+describe('Persistence', () => {
     let store: IStore;
     let mockMPInstance: IMParticleWebSDKInstance;
 
     beforeEach(() => {
         mockMPInstance = {
             _Helpers: {
                 createMainStorageName: () => 'mprtcl-v4',
-                Validators: { isFunction: () => true },
-                extend: Object.assign,
             },
             _NativeSdkHelpers: {
                 isWebviewEnabled: () => false,
@@ -31,23 +29,15 @@ describe('Persistence store', () => {
                     mockMPInstance._Persistence.setLocalStorage();
                 },
             },
-            Logger: {
-                verbose: () => {},
-                warning: () => {},
-                error: () => {},
-            },
-            Identity: {
-                getCurrentUser: () => ({ getMPID: () => 'mpid' }),
-            },
         } as unknown as IMParticleWebSDKInstance;
 
         store = {} as IStore;
         Store.call(store, {} as SDKInitConfig, mockMPInstance, 'apikey');
         window.localStorage.removeItem('mprtcl-v4');
     });
 
-    describe('#noFunctional privacy flag', () => {
-        describe('true', () => {
+    describe('#update', () => {
+        describe('noFunctional privacy flag set to true', () => {
             beforeEach(() => {
                 store.setNoFunctional(true);
                 store.webviewBridgeEnabled = false;
@@ -74,7 +64,7 @@ describe('Persistence store', () => {
             });
         });
 
-        describe('false', () => {
+        describe('noFunctional privacy flag set to false', () => {
             beforeEach(() => {
                 store.setNoFunctional(false);
                 store.webviewBridgeEnabled = false;
@@ -101,7 +91,7 @@ describe('Persistence store', () => {
             });
         });
 
-        describe('is false by default', () => {
+        describe('noFunctional privacy flag set to false by default', () => {
             beforeEach(() => {
                 // default is false
                 store.webviewBridgeEnabled = false;

test/src/tests-persistence.ts

@@ -1949,12 +1949,12 @@ describe('persistence', () => {
         user2.getAllUserAttributes()['ua-1'].should.equal('a');
     });
 
-    describe('#noFunctional', () => {
+    describe('noFunctional privacy flag', () => {
         beforeEach(() => {
             mParticle._resetForTests(MPConfig);
         });
 
-        describe('true', () => {
+        describe('set to true', () => {
             beforeEach(() => {
                 mParticle.config.launcherOptions = { noFunctional: true };
             });
@@ -1982,7 +1982,7 @@ describe('persistence', () => {
             });
         });
 
-        describe('false', () => {
+        describe('set to false', () => {
             beforeEach(() => {
                 mParticle.config.launcherOptions = { noFunctional: false };
             });