feat: define reporting service contracts and dispatchers (#1224)

Author: alexs-mparticle

src/constants.ts

@@ -139,8 +139,6 @@ const Constants = {
         identityUrl: 'identity.mparticle.com/v1/',
         aliasUrl: 'jssdks.mparticle.com/v1/identity/',
         userAudienceUrl: 'nativesdks.mparticle.com/v1/',
-        loggingUrl: 'apps.rokt-api.com/v1/log',
-        errorUrl: 'apps.rokt-api.com/v1/errors',
     },
     // These are the paths that are used to construct the CNAME urls
     CNAMEUrlPaths: {
@@ -150,8 +148,6 @@ const Constants = {
         configUrl: '/tags/JS/v2/',
         identityUrl: '/identity/v1/',
         aliasUrl: '/webevents/v1/identity/',
-        loggingUrl: '/v1/log',
-        errorUrl: '/v1/errors',
     },
     Base64CookieKeys: {
         csm: 1,

src/identityApiClient.ts

@@ -25,7 +25,7 @@ import {
     IIdentityResponse,
 } from './identity-user-interfaces';
 import { IMParticleWebSDKInstance } from './mp-instance';
-import { ErrorCodes } from './logging/types';
+import { ErrorCodes, WSDKErrorSeverity } from './reporting/types';
 
 const { HTTPCodes, Messages, IdentityMethods } = Constants;
 
@@ -201,7 +201,7 @@ export default function IdentityAPIClient(
         }
 
         const { invokeCallback } = mpInstance._Helpers;
-        const { Logger } = mpInstance;
+        const { Logger, _ErrorReportingDispatcher: errorReporter } = mpInstance;
         Logger.verbose(Messages.InformationMessages.SendIdentityBegin);
         if (!identityApiRequest) {
             Logger.error(Messages.ErrorMessages.APIRequestEmpty);
@@ -339,10 +339,13 @@ export default function IdentityAPIClient(
             }
 
             const errorMessage = (err as Error).message || err.toString();
-            Logger.error(
-                'Error sending identity request to servers' + ' - ' + errorMessage,
-                ErrorCodes.IDENTITY_REQUEST
-            );
+            const msg = 'Error sending identity request to servers' + ' - ' + errorMessage;
+            Logger.error(msg);
+            errorReporter?.report({
+                message: msg,
+                code: ErrorCodes.IDENTITY_REQUEST,
+                severity: WSDKErrorSeverity.ERROR,
+            });
 
             mpInstance.processQueueOnIdentityFailure?.();
             invokeCallback(callback, HTTPCodes.noHttpCoverage, errorMessage);

src/logger.ts

@@ -1,25 +1,19 @@
 import { LogLevelType, SDKInitConfig, SDKLoggerApi } from './sdkRuntimeModels';
-import { ReportingLogger } from './logging/reportingLogger';
-import { ErrorCodes } from './logging/types';
 
 export type ILoggerConfig = Pick<SDKInitConfig, 'logLevel' | 'logger'>;
 export type IConsoleLogger = Partial<Pick<SDKLoggerApi, 'error' | 'warning' | 'verbose'>>;
 
 export class Logger {
     private logLevel: LogLevelType;
     private logger: IConsoleLogger;
-    private reportingLogger: ReportingLogger;
 
-    constructor(config: ILoggerConfig,
-        reportingLogger?: ReportingLogger,
-    ) {
+    constructor(config: ILoggerConfig) {
         this.logLevel = config.logLevel ?? LogLevelType.Warning;
         this.logger = config.logger ?? new ConsoleLogger();
-        this.reportingLogger = reportingLogger;
     }
 
     public verbose(msg: string): void {
-        if(this.logLevel === LogLevelType.None) 
+        if(this.logLevel === LogLevelType.None)
             return;
 
         if (this.logger.verbose && this.logLevel === LogLevelType.Verbose) {
@@ -37,15 +31,12 @@ export class Logger {
         }
     }
 
-    public error(msg: string, codeForReporting?: ErrorCodes): void {
+    public error(msg: string): void {
         if(this.logLevel === LogLevelType.None)
             return;
 
         if (this.logger.error) {
             this.logger.error(msg);
-            if (codeForReporting) {
-                this.reportingLogger?.error(msg, codeForReporting);
-            }
         }
     }