chore: add attribute logging in selectPlacements

Author: jaissica12

src/roktManager.ts

@@ -184,6 +184,7 @@ export default class RoktManager {
             const { attributes } = options;
             const sandboxValue = attributes?.sandbox || null;
             const mappedAttributes = this.mapPlacementAttributes(attributes, this.placementAttributesMapping);
+            this.logger?.verbose(`MParticle.Rokt selectPlacements called with attributes: ${JSON.stringify(attributes)}`);
 
             // Get current user identities
             this.currentUser = this.identityService.getCurrentUser();
@@ -245,7 +246,6 @@ export default class RoktManager {
             const enrichedOptions = {
                 ...options,
                 attributes: enrichedAttributes,
-                initialAttributes: attributes,
             };
 
             return this.kit.selectPlacements(enrichedOptions);

test/jest/roktManager.spec.ts

@@ -594,10 +594,6 @@ describe('RoktManager', () => {
                     mapped_key: 'test_value',  // This key should be mapped
                     other_attr: 'other_value'  // This key should remain unchanged
                 },
-                initialAttributes: {
-                    original_key: 'test_value',
-                    other_attr: 'other_value'
-                }
             };
 
             expect(kit.selectPlacements).toHaveBeenCalledWith(expectedMappedOptions);
@@ -664,7 +660,6 @@ describe('RoktManager', () => {
             roktManager.selectPlacements(options);
             expect(kit.selectPlacements).toHaveBeenCalledWith({
                 attributes: {},
-                initialAttributes: {}
             });
         });
 
@@ -705,13 +700,6 @@ describe('RoktManager', () => {
                     isActive: false,
                     interests: 'sports,music,books'
                 },
-                initialAttributes: {
-                    age: 25,
-                    score: 100.5,
-                    isSubscribed: true,
-                    isActive: false,
-                    interests: 'sports,music,books'
-                }
             });
         });
 
@@ -776,7 +764,6 @@ describe('RoktManager', () => {
             expect(roktManager['messageQueue'].size).toBe(0);
             expect(kit.selectPlacements).toHaveBeenCalledWith({
                 attributes: {},
-                initialAttributes: {}
             });
             expect(result).toEqual(expectedResult);
         });
@@ -825,13 +812,6 @@ describe('RoktManager', () => {
                     isActive: false,
                     interests: 'sports,music,books'
                 },
-                initialAttributes: {
-                    age: 25,
-                    score: 100.5,
-                    isSubscribed: true,
-                    isActive: false,
-                    interests: 'sports,music,books'
-                }
             };
 
             roktManager.selectPlacements(options);
@@ -872,10 +852,6 @@ describe('RoktManager', () => {
                     sandbox: true
                 },
                 identifier: 'test-identifier',
-                initialAttributes: {
-                    customAttr: 'value',
-                    sandbox: true
-                }
             }); 
         });
 
@@ -913,10 +889,6 @@ describe('RoktManager', () => {
                     customAttr: 'value',
                     sandbox: false
                 },
-                initialAttributes: {
-                    customAttr: 'value',
-                    sandbox: false
-                }
             });
         });
 
@@ -954,10 +926,6 @@ describe('RoktManager', () => {
                     sandbox: true
                 },
                 identifier: 'test-identifier',
-                initialAttributes: {
-                    customAttr: 'value',
-                    sandbox: true
-                }
             });
         });
 
@@ -1004,11 +972,6 @@ describe('RoktManager', () => {
                     lastname: 'Doe',
                     score: 42,
                 },
-                initialAttributes: {
-                    'f.name': 'John',
-                    'last_name': 'Doe',
-                    'score': 42,
-                }
             };
 
             roktManager.selectPlacements(options);
@@ -1048,57 +1011,64 @@ describe('RoktManager', () => {
                     'score': 42,
                     'age': 25,
                 },
-                initialAttributes: {
-                    'f.name': 'John',
-                    'last_name': 'Doe',
-                    'score': 42,
-                    'age': 25,
-                }
             });
         });
 
-        it('should pass initialAttributes to kit for event logging', () => {
+        it('should log developer passed attributes via verbose logger', async () => {
             const kit: Partial<IRoktKit> = {
                 launcher: {
                     selectPlacements: jest.fn(),
                     hashAttributes: jest.fn(),
                     use: jest.fn(),
                 },
                 hashAttributes: jest.fn(),
-                selectPlacements: jest.fn(),
+                selectPlacements: jest.fn().mockResolvedValue({}),
                 setExtensionData: jest.fn(),
                 use: jest.fn(),
             };
 
             roktManager.kit = kit as IRoktKit;
             roktManager['placementAttributesMapping'] = [];
 
+            const mockIdentity = {
+                getCurrentUser: jest.fn().mockReturnValue({
+                    getUserIdentities: () => ({
+                        userIdentities: {}
+                    }),
+                    setUserAttributes: jest.fn()
+                }),
+                identify: jest.fn()
+            } as unknown as SDKIdentityApi;
+
+            roktManager['identityService'] = mockIdentity;
+
             const options: IRoktSelectPlacementsOptions = {
                 attributes: {
                     'customAttr': 'value',
                 }
             };
 
-            roktManager.selectPlacements(options);
+            await roktManager.selectPlacements(options);
 
-            expect(kit.selectPlacements).toHaveBeenCalledWith(
-                expect.objectContaining({
-                    initialAttributes: {
-                        'customAttr': 'value',
-                    }
-                })
+            expect(mockMPInstance.Logger.verbose).toHaveBeenCalledWith(
+                'MParticle.Rokt selectPlacements called with attributes: {"customAttr":"value"}'
             );
+            expect(kit.selectPlacements).toHaveBeenCalledWith({
+                attributes: {
+                    'customAttr': 'value',
+                }
+            });
         });
 
-        it('should include original attributes in initialAttributes even after mapping', () => {
+        it('should log original attributes even after mapping', async () => {
             const kit: Partial<IRoktKit> = {
                 launcher: {
                     selectPlacements: jest.fn(),
                     hashAttributes: jest.fn(),
                     use: jest.fn(),
                 },
                 hashAttributes: jest.fn(),
-                selectPlacements: jest.fn(),
+                selectPlacements: jest.fn().mockResolvedValue({}),
                 setExtensionData: jest.fn(),
                 use: jest.fn(),
             };
@@ -1113,29 +1083,38 @@ describe('RoktManager', () => {
                 }
             ];
 
+            const mockIdentity = {
+                getCurrentUser: jest.fn().mockReturnValue({
+                    getUserIdentities: () => ({
+                        userIdentities: {}
+                    }),
+                    setUserAttributes: jest.fn()
+                }),
+                identify: jest.fn()
+            } as unknown as SDKIdentityApi;
+
+            roktManager['identityService'] = mockIdentity;
+
             const options: IRoktSelectPlacementsOptions = {
                 attributes: {
                     'f.name': 'John',
                     'userId': 'user123',
                 }
             };
 
-            roktManager.selectPlacements(options);
+            await roktManager.selectPlacements(options);
 
-            // initialAttributes should contain the ORIGINAL unmapped attributes
-            expect(kit.selectPlacements).toHaveBeenCalledWith(
-                expect.objectContaining({
-                    initialAttributes: {
-                        'f.name': 'John',
-                        'userId': 'user123',
-                    },
-                    // attributes should be mapped
-                    attributes: {
-                        'firstname': 'John',
-                        'userId': 'user123',
-                    }
-                })
+
+            expect(mockMPInstance.Logger.verbose).toHaveBeenCalledWith(
+                'MParticle.Rokt selectPlacements called with attributes: {"f.name":"John","userId":"user123"}'
             );
+
+            expect(kit.selectPlacements).toHaveBeenCalledWith({
+                attributes: {
+                    'firstname': 'John',
+                    'userId': 'user123',
+                }
+            });
         });
 
         it('should set the mapped attributes on the current user via setUserAttributes', async () => {
@@ -1230,10 +1209,6 @@ describe('RoktManager', () => {
                     'email': 'test@example.com',
                     'sandbox': true
                 },
-                initialAttributes: {
-                    'email': 'test@example.com',
-                    'sandbox': true,
-                }
             });
 
             expect(setUserAttributesSpy).not.toHaveBeenCalledWith({