test: added jest tests and updated test content

Author: jaissica12

src/persistence.js

@@ -88,14 +88,10 @@ export default function _Persistence(mpInstance) {
 
             // https://go.mparticle.com/work/SQDSDKS-6048
             try {
-                if (mpInstance._Store.isLocalStorageAvailable) {
-                    if (mpInstance._Store.getNoTargeting()) {
-                        localStorage.removeItem(
-                            mpInstance._Store.prodStorageName
-                        );
-                        mpInstance._Store.cartProducts = [];
-                        return;
-                    }
+                if (
+                    mpInstance._Store.isLocalStorageAvailable &&
+                    !mpInstance._Store.getNoTargeting()
+                ) {
                     var encodedProducts = localStorage.getItem(
                         mpInstance._Store.prodStorageName
                     );
@@ -363,11 +359,7 @@ export default function _Persistence(mpInstance) {
             };
 
         if (mpInstance._Store.getNoTargeting()) {
-            try {
-                window.localStorage.removeItem(
-                    mpInstance._Store.prodStorageName
-                );
-            } catch (e) {}
+            return;
         }
         if (mpid) {
             allLocalStorageProducts = allLocalStorageProducts || {};
@@ -945,13 +937,10 @@ export default function _Persistence(mpInstance) {
     };
 
     this.setCartProducts = function(allProducts) {
-        if (!mpInstance._Store.isLocalStorageAvailable) {
-            return;
-        }
-        if (mpInstance._Store.getNoTargeting()) {
-            try {
-                localStorage.removeItem(mpInstance._Store.prodStorageName);
-            } catch (e) {}
+        if (
+            !mpInstance._Store.isLocalStorageAvailable &&
+            mpInstance._Store.getNoTargeting()
+        ) {
             return;
         }
 

test/jest/persistence.spec.ts

@@ -0,0 +1,33 @@
+import {
+  mParticle,
+  MPConfig,
+  testMPID,
+} from '../src/config/constants';
+
+describe('Products Persistence', () => {
+    let mpInstance = mParticle.getInstance();
+    beforeEach(() => {
+        mParticle._resetForTests(MPConfig);
+    });
+
+    it('should update Products localStorage when noTargeting is false by default', () => {
+        const product = { Name: 'iphone', Sku: 'iphonesku', Price: 599, Quantity: 1 };
+        mpInstance._Persistence.setCartProducts({ [testMPID]: { cp: [product] } } as any);
+        expect(mpInstance._Persistence.getCartProducts(testMPID).length).toBe(1);
+    });
+
+    it('should NOT update Products localStorage when noTargeting is true', () => {
+        mpInstance._Store.setNoTargeting(true);
+        const product = { Name: 'iphone', Sku: 'iphonesku', Price: 599, Quantity: 1 };
+        mpInstance._Persistence.setCartProducts({ [testMPID]: { cp: [product] } } as any);
+        expect(mpInstance._Persistence.getCartProducts(testMPID).length).toBe(0);
+        expect(mpInstance._Persistence.getCartProducts(testMPID)).toEqual([]);
+    });
+
+    it('should update Products localStorage when noTargeting is false', () => {
+        mpInstance._Store.setNoTargeting(false);
+        const product = { Name: 'iphone', Sku: 'iphonesku', Price: 599, Quantity: 1 };
+        mpInstance._Persistence.setCartProducts({ [testMPID]: { cp: [product] } } as any);
+        expect(mpInstance._Persistence.getCartProducts(testMPID).length).toBe(1);
+    });
+});

test/src/tests-persistence.ts

@@ -1674,18 +1674,6 @@ describe('persistence', () => {
             const localStorageProducts = localStorage.getItem(LocalStorageProductsV4WithWorkSpaceName);
             expect(localStorageProducts).to.not.be.ok;
         });
-
-        it('should clear existing products LS when noTargeting is true', async () => {
-            localStorage.setItem(
-                LocalStorageProductsV4WithWorkSpaceName,
-                btoa(JSON.stringify({ testMPID: { cp: [{ Name: 'x' }] } }))
-            );
-            mParticle.config.noTargeting = true;
-            mParticle.init(apiKey, mParticle.config);
-            await waitForCondition(hasIdentifyReturned);
-            const localStorageProducts = localStorage.getItem(LocalStorageProductsV4WithWorkSpaceName);
-            expect(localStorageProducts).to.not.be.ok;
-        });
 
         it('should save products LS when noTargeting is false', async () => {
             mParticle.config.noTargeting = false;
@@ -1704,7 +1692,7 @@ describe('persistence', () => {
             expect(localStorageProducts).to.be.ok;
         });
 
-        it('should save products LS when noTargeting is default (false)', async () => {
+        it('should save products LS when noTargeting is false by default', async () => {
             mParticle.init(apiKey, mParticle.config);
             await waitForCondition(hasIdentifyReturned);
             const iphone = mParticle.eCommerce.createProduct(