chore: simplify StorageTypes for better type safety

Author: jaissica12

src/constants.ts

@@ -219,10 +219,10 @@ export const HTTP_SERVER_ERROR = 500 as const;
 // Privacy dependency map for storage keys
 export type PrivacyControl = 'functional' | 'targeting';
 
-export const StorageTypes = ['SDKState', 'Products', 'Events', 'Batches', 'IdCache', 'TimeOnSite'];
+export type StorageTypes = 'SDKState' | 'Products' | 'Events' | 'Batches' | 'IdCache' | 'TimeOnSite';
 
-export const StoragePrivacyMap: Record<typeof StorageTypes[number], PrivacyControl> = {
-    SDKState : 'functional',
+export const StoragePrivacyMap: Record<StorageTypes, PrivacyControl> = {
+    SDKState: 'functional',
     Products: 'targeting',
     Events: 'functional',
     Batches: 'functional',

src/store.ts

@@ -8,7 +8,7 @@ import {
     UserIdentities,
 } from '@mparticle/web-sdk';
 import { IKitConfigs } from './configAPIClient';
-import Constants, { StoragePrivacyMap, StorageTypes } from './constants';
+import Constants, { PrivacyControl, StoragePrivacyMap, StorageTypes } from './constants';
 import {
     DataPlanResult,
     KitBlockerOptions,
@@ -201,7 +201,7 @@ export interface IStore {
     setNoFunctional?(noFunctional: boolean): void;
     getNoTargeting?(): boolean;
     setNoTargeting?(noTargeting: boolean): void;
-    getPrivacyFlag?(storageType: typeof StorageTypes[number]): boolean;
+    getPrivacyFlag?(storageType: StorageTypes): boolean;
 
     getDeviceId?(): string;
     setDeviceId?(deviceId: string): void;
@@ -591,8 +591,8 @@ export default function Store(
         this.noTargeting = noTargeting;
     };
 
-    this.getPrivacyFlag = (storageType: typeof StorageTypes[number]): boolean => {
-        const privacyControl = StoragePrivacyMap[storageType];
+    this.getPrivacyFlag = (storageType: StorageTypes): boolean => {
+        const privacyControl: PrivacyControl = StoragePrivacyMap[storageType];
         if (privacyControl === 'functional') {
             return this.getNoFunctional();
         }

test/jest/batchUploader.spec.ts

@@ -22,7 +22,7 @@ describe('BatchUploader', () => {
                 storageName: 'mprtcl-v4_abcdef',
                 getNoFunctional: function(this: any) { return this.noFunctional; },
                 getNoTargeting: function(this: any) { return this.noTargeting; },
-                getPrivacyFlag: function(this: any, storageType: typeof StorageTypes[number]) {
+                getPrivacyFlag: function(this: any, storageType: StorageTypes) {
                     const privacyControl = StoragePrivacyMap[storageType];
                     if (privacyControl === 'functional') {
                         return this.getNoFunctional();