fix: Coerce event name to string (#1234)

* fix: Coerce event name to string

* fix: update EventName comparisons and tests for string coercion

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Move waitForCondition to beforeEach

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: jamesnrokt

src/apiClient.ts

@@ -176,7 +176,7 @@ export default function APIClient(
         // https://go.mparticle.com/work/SQDSDKS-6935
         // While Event Name is 'usually' a string, there are some cases where it is a number
         // in that it could be a type of MessageType Enum
-        if (event.EventName as unknown as number !== Types.MessageType.AppStateTransition) {
+        if (event.EventName !== String(Types.MessageType.AppStateTransition)) {
             if (kitBlocker && kitBlocker.kitBlockingEnabled) {
                 event = kitBlocker.createBlockedEvent(event);
             }

src/serverModel.ts

@@ -302,7 +302,7 @@ export default function ServerModel(
                     //  events do not have names, but are denoted by their `event_type`
                     EventName:
                         event.name ||
-                        ((event.messageType as unknown) as string),
+                        String(event.messageType),
                     EventCategory: event.eventType,
                     EventAttributes: mpInstance._Helpers.sanitizeAttributes(
                         event.data,

test/src/tests-batchUploader_3.ts

@@ -130,8 +130,8 @@ describe('batch uploader', () => {
             let pendingEvents = window.mParticle.getInstance()._APIClient.uploader.eventsQueuedForProcessing;
 
             pendingEvents.length.should.equal(3);
-            pendingEvents[0].EventName.should.equal(1);
-            pendingEvents[1].EventName.should.equal(10);
+            pendingEvents[0].EventName.should.equal('1');
+            pendingEvents[1].EventName.should.equal('10');
             pendingEvents[2].EventName.should.equal('Test Event');
 
             fetchMock.post(urls.events, 200);

test/src/tests-batchUploader_4.ts

@@ -201,8 +201,8 @@ describe('batch uploader', () => {
             const pendingEvents = window.mParticle.getInstance()._APIClient.uploader.eventsQueuedForProcessing;
 
             pendingEvents.length.should.equal(3)
-            pendingEvents[0].EventName.should.equal(1);
-            pendingEvents[1].EventName.should.equal(10);
+            pendingEvents[0].EventName.should.equal('1');
+            pendingEvents[1].EventName.should.equal('10');
             pendingEvents[2].EventName.should.equal('Test Event');
 
             window.mParticle.upload();

test/src/tests-forwarders.ts

@@ -2236,7 +2236,7 @@ describe('forwarders', function() {
         mParticle.init(apiKey, window.mParticle.config);
         await waitForCondition(hasIdentityCallInflightReturned);
 
-        window.MockForwarder1.instance.receivedEvent.EventName.should.equal(1);
+        window.MockForwarder1.instance.receivedEvent.EventName.should.equal('1');
         window.MockForwarder1.instance.receivedEvent = null;
 
         mParticle.logEvent(
@@ -2271,7 +2271,7 @@ describe('forwarders', function() {
         mParticle.init(apiKey, window.mParticle.config);
         await waitForCondition(hasIdentityCallInflightReturned);
 
-        window.MockForwarder1.instance.receivedEvent.EventName.should.equal(1);
+        window.MockForwarder1.instance.receivedEvent.EventName.should.equal('1');
         window.MockForwarder1.instance.receivedEvent = null;
 
         mParticle.logEvent(

test/src/tests-serverModel.ts

@@ -468,6 +468,68 @@ describe('ServerModel', () => {
             expect(mPStore.sessionStartDate).to.eql(null);
         });
 
+        describe('EventName coercion for lifecycle events with no name', () => {
+            beforeEach(async () => {
+                await waitForCondition(hasIdentifyReturned);
+            });
+
+            it('should produce a string EventName for SessionStart', () => {
+                const event: BaseEvent = {
+                    messageType: Types.MessageType.SessionStart,
+                    eventType: Types.EventType.Other,
+                };
+
+                const actualEventObject = mParticle
+                    .getInstance()
+                    ._ServerModel.createEventObject(event) as IUploadObject;
+
+                expect(typeof actualEventObject.EventName).to.equal('string');
+                expect(actualEventObject.EventName).to.equal('1');
+            });
+
+            it('should produce a string EventName for SessionEnd', () => {
+                const event: BaseEvent = {
+                    messageType: Types.MessageType.SessionEnd,
+                    eventType: Types.EventType.Other,
+                };
+
+                const actualEventObject = mParticle
+                    .getInstance()
+                    ._ServerModel.createEventObject(event) as IUploadObject;
+
+                expect(typeof actualEventObject.EventName).to.equal('string');
+                expect(actualEventObject.EventName).to.equal('2');
+            });
+
+            it('should produce a string EventName for AppStateTransition', () => {
+                const event: BaseEvent = {
+                    messageType: Types.MessageType.AppStateTransition,
+                    eventType: Types.EventType.Other,
+                };
+
+                const actualEventObject = mParticle
+                    .getInstance()
+                    ._ServerModel.createEventObject(event) as IUploadObject;
+
+                expect(typeof actualEventObject.EventName).to.equal('string');
+                expect(actualEventObject.EventName).to.equal('10');
+            });
+
+            it('should use the event name when provided, not the messageType', () => {
+                const event: BaseEvent = {
+                    name: 'My Custom Event',
+                    messageType: Types.MessageType.PageEvent,
+                    eventType: Types.EventType.Navigation,
+                };
+
+                const actualEventObject = mParticle
+                    .getInstance()
+                    ._ServerModel.createEventObject(event) as IUploadObject;
+
+                expect(actualEventObject.EventName).to.equal('My Custom Event');
+            });
+        });
+
         it('should set necessary attributes if MessageType is AppStateTransition', () => {
             const event: BaseEvent = {
                 name: 'Test Event',