feat: added noFunctional and noTargeting flags#1059
Merged
jaissica12 merged 5 commits intoSep 8, 2025
Merged
Conversation
rmi22186
reviewed
Aug 27, 2025
| }); | ||
|
|
||
| // Default case | ||
| it('defaults to false when not provided', () => { |
Member
There was a problem hiding this comment.
i'd be more specific
Suggested change
| it('defaults to false when not provided', () => { | |
| it('defaults noFunctional and noTargeting to false when not provided', () => { |
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback! Will update it
Comment on lines
+1679
to
+1680
| (window.mParticle.config).noFunctional = true; | ||
| (window.mParticle.config).noTargeting = true; |
Member
There was a problem hiding this comment.
any reason for the parentheses?
Suggested change
| (window.mParticle.config).noFunctional = true; | |
| (window.mParticle.config).noTargeting = true; | |
| window.mParticle.config.noFunctional = true; | |
| window.mParticle.config.noTargeting = true; |
rmi22186
approved these changes
Aug 28, 2025
…ting-privacy-flags-in-store
|
Collaborator
|
🎉 This PR is included in version 2.45.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
noTargetingnoFunctionalwhich will be extracted fromconfigand used further to evaluate local storage / cookie.Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)