feat: added noFunctional in batchUploader to disable offline storage#1063

Merged

jaissica12 merged 15 commits into

developmentfrom

feat/SDKE-68-disable-offline-storage-for-events-batches-when-noFunctional-is-set

Sep 19, 2025

jaissica12 commented Sep 2, 2025 •

edited

Loading

Contributor

Instructions

PR target branch should be against development
PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Added noFunctional to the batchUploadersuch that offlineStorageEnabled is true when is noFunctional false

Testing Plan

Was this tested locally? If not, explain why.
{explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Closes https://rokt.atlassian.net/browse/SDKE-68

jaissica12 changed the title ~~feat: added noFunctional in batchUploader and updated tests~~ feat: added noFunctional in batchUploader to disable offline storage

jaissica12 marked this pull request as ready for review

September 2, 2025 20:00

jaissica12 requested review from alexs-mparticle and rmi22186

September 2, 2025 20:00

alexs-mparticle requested changes

View reviewed changes

test/jest/batchUploader.spec.ts Outdated

test/src/tests-batchUploader.ts Outdated

rmi22186 reviewed

View reviewed changes

src/store.ts Outdated

rmi22186 reviewed

View reviewed changes

src/constants.ts Outdated

rmi22186 reviewed

View reviewed changes

test/jest/batchUploader.spec.ts Outdated

jaissica12 requested review from alexs-mparticle and rmi22186

September 5, 2025 16:35

rmi22186 reviewed

View reviewed changes

src/batchUploader.ts Outdated

rmi22186 reviewed

View reviewed changes

src/constants.ts Outdated

rmi22186 reviewed

View reviewed changes

src/constants.ts Outdated

rmi22186 reviewed

View reviewed changes

test/src/tests-batchUploader.ts Outdated

rmi22186 reviewed

View reviewed changes

test/jest/batchUploader.spec.ts

rmi22186 reviewed

View reviewed changes

test/jest/batchUploader.spec.ts

rmi22186 reviewed

View reviewed changes

test/src/tests-batchUploader.ts Outdated

rmi22186 reviewed

View reviewed changes

test/src/tests-batchUploader.ts Outdated

rmi22186 reviewed

View reviewed changes

test/src/tests-batchUploader.ts Outdated

rmi22186 reviewed

View reviewed changes

test/src/tests-batchUploader.ts Outdated

rmi22186 reviewed

View reviewed changes

test/src/tests-batchUploader.ts Outdated

rmi22186 reviewed

View reviewed changes

test/src/tests-batchUploader.ts Outdated

rmi22186 requested changes

View reviewed changes

rmi22186 left a comment

Member

looking good. a few minor changes. nothing significant to the code. more naming of things. Def push back if you disagree.

jaissica12 requested a review from rmi22186

September 9, 2025 22:59

rmi22186 reviewed

View reviewed changes

test/jest/batchUploader.spec.ts

rmi22186 reviewed

View reviewed changes

test/jest/batchUploader.spec.ts Outdated

rmi22186 reviewed

View reviewed changes

test/src/tests-batchUploader.ts Outdated

jaissica12 requested a review from rmi22186

September 10, 2025 13:41

alexs-mparticle requested changes

View reviewed changes

src/store.ts Outdated

jaissica12 requested a review from alexs-mparticle

September 12, 2025 00:22

Jaissica Hora and others added 9 commits

September 18, 2025 11:16


          chore: removed extra comment and updated storage privacy map

5d31724


          chore: remove redundant boolean coercion

e706b5b


          test: updated tests for batchUploader

47b7113


          test: updated tests for batchUploader

aaacb9c


          refactor: renamed getPrivacyFlagForStorage to getPrivacyFlag

0b69930


          chore: simplify StorageTypes for better type safety

57823b6


          chore: revert to offlineStorageEnabled and update StorageTypes

e7ad62e


          chore: updated test content and removed comment

3b0b0eb


          chore: updated jest and integration test message

db8c08e

jaissica12 force-pushed the feat/SDKE-68-disable-offline-storage-for-events-batches-when-noFunctional-is-set branch from ebb8b48 to db8c08e Compare

September 18, 2025 15:20

rmi22186 reviewed

View reviewed changes

test/src/tests-batchUploader.ts Outdated

rmi22186 reviewed

View reviewed changes

test/src/tests-batchUploader.ts

rmi22186 reviewed

View reviewed changes

test/src/tests-batchUploader.ts

rmi22186 reviewed

View reviewed changes

test/src/tests-batchUploader.ts

rmi22186 reviewed

View reviewed changes

test/src/tests-batchUploader.ts

rmi22186 reviewed

View reviewed changes

test/src/tests-batchUploader.ts


          test: updated tests for batch uploader

426f038

jaissica12 requested review from alexs-mparticle and rmi22186

September 18, 2025 16:46


          test: updated tests for batch uploader

3b3b9b3

sonarqubecloud Bot commented Sep 18, 2025

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rmi22186 approved these changes

View reviewed changes

alexs-mparticle approved these changes

View reviewed changes

This was referenced Sep 18, 2025

feat: disable time tracking when noTargeting is set to true #1064

Merged

feat: disable product cookie when no targeting is true #1071

Closed

feat: added DisabledVault to disable id-cache when noFunctional is set #1072

Merged

jaissica12 merged commit 97dd88a into development

63 of 70 checks passed

github-actions Bot pushed a commit that referenced this pull request


          chore(release): 2.47.0 [skip ci]

495c955

# [2.47.0](v2.46.0...v2.47.0) (2025-10-01)

### Bug Fixes

* SDKE-317 Call deferred methods on Rokt Manager instead of kit ([#1076](#1076)) ([3a0643b](3a0643b))

### Features

* added DisabledVault to disable id-cache when noFunctional is set ([#1072](#1072)) ([8187d72](8187d72))
* added noFunctional in batchUploader to disable offline storage ([#1063](#1063)) ([97dd88a](97dd88a))
* disable session cookie/localStorage when noFunctional is set ([#1070](#1070)) ([edb2e61](edb2e61))
* disable time tracking when noTargeting is set to true ([#1064](#1064)) ([71c891c](71c891c))

mparticle-automation commented Oct 1, 2025

Collaborator

🎉 This PR is included in version 2.47.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mparticle-automation added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels