Skip to content

feat: disable time tracking when noTargeting is set to true#1064

Merged
jaissica12 merged 9 commits into
developmentfrom
feat/SDKE-90-disable-persisting-time-on-site-when-noTargeting-is-set
Sep 23, 2025
Merged

feat: disable time tracking when noTargeting is set to true#1064
jaissica12 merged 9 commits into
developmentfrom
feat/SDKE-90-disable-persisting-time-on-site-when-noTargeting-is-set

Conversation

@jaissica12

Copy link
Copy Markdown
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Updated store.ts such that _timeOnSiteTimer is initialized only if noTargeting is false.

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@jaissica12 jaissica12 marked this pull request as ready for review September 2, 2025 21:41
Comment thread test/jest/foregroundTimeTracker.spec.ts Outdated
Comment thread test/jest/foregroundTimeTracker.spec.ts Outdated
Comment thread test/jest/foregroundTimeTracker.spec.ts Outdated
Comment thread test/jest/foregroundTimeTracker.spec.ts Outdated
@jaissica12 jaissica12 changed the base branch from feat/SDKE-69-add-noFunctional-noTargeting-privacy-flags-in-store to development September 18, 2025 15:02
@jaissica12 jaissica12 force-pushed the feat/SDKE-90-disable-persisting-time-on-site-when-noTargeting-is-set branch from 9fdb6be to b3d1941 Compare September 18, 2025 15:08

@rmi22186 rmi22186 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine but needs to be rebased against #1063 and logic need to be updated using mpInstance._Store.getPrivacyFlag

Comment thread src/store.ts Outdated

@rmi22186 rmi22186 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaissica12 jaissica12 requested a review from rmi22186 September 22, 2025 20:46
Comment thread src/store.ts Outdated
@sonarqubecloud

Copy link
Copy Markdown

@jaissica12 jaissica12 merged commit 71c891c into development Sep 23, 2025
64 of 72 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 1, 2025
# [2.47.0](v2.46.0...v2.47.0) (2025-10-01)

### Bug Fixes

* SDKE-317 Call deferred methods on Rokt Manager instead of kit ([#1076](#1076)) ([3a0643b](3a0643b))

### Features

* added DisabledVault to disable id-cache when noFunctional is set ([#1072](#1072)) ([8187d72](8187d72))
* added noFunctional in batchUploader to disable offline storage ([#1063](#1063)) ([97dd88a](97dd88a))
* disable session cookie/localStorage when noFunctional is set ([#1070](#1070)) ([edb2e61](edb2e61))
* disable time tracking when noTargeting is set to true ([#1064](#1064)) ([71c891c](71c891c))
@mparticle-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.47.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants