Skip to content

test: Add test to ensure null setting strings are handled properly#1069

Merged
alexs-mparticle merged 1 commit into
developmentfrom
fix/SDKE-133-add-null-check-setting
Sep 15, 2025
Merged

test: Add test to ensure null setting strings are handled properly#1069
alexs-mparticle merged 1 commit into
developmentfrom
fix/SDKE-133-add-null-check-setting

Conversation

@alexs-mparticle

Copy link
Copy Markdown
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Add test to ensure null setting strings are handled properly

Testing Plan

  • Was this tested locally? If not, explain why.
  • Using a sample app, ensure Placement Attribute Mapping is being returned as null in the kit config for the Rokt Partner Kit.
  • Ensure that verbose logging is on.
  • Ensure that no error is being thrown when setting is null.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@sonarqubecloud

Copy link
Copy Markdown

@alexs-mparticle alexs-mparticle marked this pull request as ready for review September 10, 2025 18:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a test case to verify that the parseSettingsString function correctly handles null input values by returning an empty array, ensuring robust handling of null setting strings in the codebase.

  • Added a unit test to validate null input handling for parseSettingsString

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alexs-mparticle alexs-mparticle merged commit c46fcee into development Sep 15, 2025
232 of 249 checks passed
@mparticle-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.45.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants