refactor: SDKE 283 remove cart related function from persistence#1073
Conversation
alexs-mparticle
left a comment
alexs-mparticle
left a comment
There was a problem hiding this comment.
Check with @rmi22186 for a second review since this touches a lot of older code, but it looks good to me.
| ); | ||
|
|
||
| done(); | ||
| }); |
There was a problem hiding this comment.
Hm. This is giving me some pause. I am actually not sure if Android and iOS carts are deprecated or not. Basically in web bridge mode (when MP is embedded in a web view in a native app), when a developer calls various commands, instead of going through the code of the web sdk, it will bridge to the ios/android layers and send the data to native, and native handles the rest.
@Mansi-mParticle and @BrandonStalnaker - The context here is that we have warned developers that the mParticle Cart API has been deprecated for several years now and are looking to finally remove it. However, I see code potentially touching native's addToCart and removeFromCart and clearCart. Can you confirm if the cart is deprecated? This shouldn't have anything to do with the ProductAction Enums. Maybe this is worth having a call over, or testing E2E to confirm.
There was a problem hiding this comment.
Actually I see this in Android docs, and this in iOS docs that their cart has also been deprecated...so based on that, we are good to go here.
rmi22186
left a comment
rmi22186
left a comment
There was a problem hiding this comment.
mostly nits, with one comment that might change some of the work. Let's way to hear back from Brandon/Mansi
…uments from mParticleUserCart
|
LGTM. I'd say let's confirm 100% with mansi/brandon before merging, but I'm pretty confident about it given the docs. |
…283-remove-cart-related-function-from-persistence
|
|
🎉 This PR is included in version 2.47.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)