fix: SDKE-317 Call deferred methods on Rokt Manager instead of kit#1076
Merged
rmi22186 merged 2 commits intoSep 30, 2025
Conversation
alexs-mparticle
requested changes
Sep 30, 2025
| }); | ||
|
|
||
| it('should call RoktManager methods (not kit methods directly) when processing queue', () => { | ||
| const kit: IRoktKit = { |
Collaborator
There was a problem hiding this comment.
Can we move the kit into a beforeEach? I realize I probably should have been the one to do it in the first place 😅
|
alexs-mparticle
approved these changes
Sep 30, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
# [2.47.0](v2.46.0...v2.47.0) (2025-10-01) ### Bug Fixes * SDKE-317 Call deferred methods on Rokt Manager instead of kit ([#1076](#1076)) ([3a0643b](3a0643b)) ### Features * added DisabledVault to disable id-cache when noFunctional is set ([#1072](#1072)) ([8187d72](8187d72)) * added noFunctional in batchUploader to disable offline storage ([#1063](#1063)) ([97dd88a](97dd88a)) * disable session cookie/localStorage when noFunctional is set ([#1070](#1070)) ([edb2e61](edb2e61)) * disable time tracking when noTargeting is set to true ([#1064](#1064)) ([71c891c](71c891c))
Collaborator
|
🎉 This PR is included in version 2.47.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Deferred calls happen if mParticle is ready but Rokt isn’t yet and a developer tries to call
mParticle.Rokt.METHOD_NAME. Eventually Rokt will become ready, and the deferred calls will be processed. When that happens, the current code has the deferred method called on the kit and not the Rokt Manager. This makes sense foruseandhashAttributesbecause we simply pass the data directly to the kit method. However, it doesn't work withselectPlacementsbecause we do lots of logic between RoktManager’s selectPlacements and the kit’s selectPlacements. We need to call the method on the Rokt Manager and not the kit.Testing Plan
Unit tests and local test app
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)